Skip to content

Dev/astro migration#5

Merged
mag1cfrog merged 2 commits into
mainfrom
dev/astro-migration
Jun 16, 2025
Merged

Dev/astro migration#5
mag1cfrog merged 2 commits into
mainfrom
dev/astro-migration

Conversation

@mag1cfrog
Copy link
Copy Markdown
Owner

This pull request includes updates to Node.js version, site configuration, component logic, and styling for better compatibility, maintainability, and functionality. The most important changes include upgrading the Node.js version, modifying the site base URL, improving the HeaderLink component's type safety and logic, and removing an unused import.

Environment and configuration updates:

  • .github/workflows/deploy.yml: Upgraded Node.js version from 18 to 22 in the GitHub Actions workflow to ensure compatibility with newer features and dependencies.
  • astro.config.mjs: Updated the site configuration to include the base path /spark-tuning-notes/ directly in the URL, simplifying the configuration and resolving potential path issues.

Component improvements:

  • src/components/HeaderLink.astro: Refactored the HeaderLink component to:
    • Enforce href as a string in the Props interface for better type safety.
    • Dynamically resolve the correct URL, accounting for the base path in production.
    • Simplify and improve the active-link logic for accurate path comparison.
    • Streamline class combination logic for better readability.

Code cleanup:

@mag1cfrog mag1cfrog merged commit 8983475 into main Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant