Dev/astro migration#5
Merged
Merged
Conversation
…RL resolution, and enhance active-link logic
…ort in about page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to Node.js version, site configuration, component logic, and styling for better compatibility, maintainability, and functionality. The most important changes include upgrading the Node.js version, modifying the site base URL, improving the
HeaderLinkcomponent's type safety and logic, and removing an unused import.Environment and configuration updates:
.github/workflows/deploy.yml: Upgraded Node.js version from18to22in the GitHub Actions workflow to ensure compatibility with newer features and dependencies.astro.config.mjs: Updated thesiteconfiguration to include the base path/spark-tuning-notes/directly in the URL, simplifying the configuration and resolving potential path issues.Component improvements:
src/components/HeaderLink.astro: Refactored theHeaderLinkcomponent to:hrefas a string in thePropsinterface for better type safety.Code cleanup:
src/pages/about.astro: Commented out an unused import (AboutHeroImage) to reduce unnecessary code.