Skip to content

Conversation

@fballiano
Copy link
Contributor

@fballiano fballiano commented May 20, 2025

This PR adds:

  • bin/download-all-missing-packages-from-repo-magento-com.php that looks for the lastest patch release for every mirrored release and download the missing packages from repo.magento.com
  • adds a workflow running at midnight (or manually) that executes the script above and, if there are changes, it creates a PR to add the downloaded packages

The downloader script has been tested and it works correctly, the workflow (as it is) it's really hard to test

@fballiano fballiano requested a review from a team as a code owner May 20, 2025 18:53
@fballiano fballiano requested review from Vinai and rhoerr May 20, 2025 18:56
@Vinai
Copy link
Contributor

Vinai commented May 22, 2025

Wow, this is a great idea @fballiano!

Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al long as we check the packages in the PRs the first few times with extra care this LGTM!

@Vinai
Copy link
Contributor

Vinai commented May 22, 2025

I'll wait for your approval, too, before merging @rhoerr

Copy link
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not personally tested to verify, but the code and concept seem good to me in principle. Let's try it.

Great idea, thank you Fabrizio. This will make mirror management a bunch easier.

@rhoerr rhoerr merged commit a284c93 into mage-os:main May 27, 2025
1 check passed
@rhoerr
Copy link
Contributor

rhoerr commented May 27, 2025

Workflow fails with an error in "Run mirror script":

https://github.com/mage-os/generate-mirror-repo-js/actions/runs/15265699566/job/42930858142

Error: Cannot find module 'parse-options'
Require stack:
- /home/runner/work/generate-mirror-repo-js/generate-mirror-repo-js/src/make/mirror.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1212:15)
    at Module._load (node:internal/modules/cjs/loader:1043:27)
    at Module.require (node:internal/modules/cjs/loader:1298:19)
    at require (node:internal/modules/helpers:182:18)
    at Object.<anonymous> (/home/runner/work/generate-mirror-repo-js/generate-mirror-repo-js/src/make/mirror.js:2:22)
    at Module._compile (node:internal/modules/cjs/loader:1529:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:16[13](https://github.com/mage-os/generate-mirror-repo-js/actions/runs/15265699566/job/42930858142#step:6:14):10)
    at Module.load (node:internal/modules/cjs/loader:1275:32)
    at Module._load (node:internal/modules/cjs/loader:1096:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:[16](https://github.com/mage-os/generate-mirror-repo-js/actions/runs/15265699566/job/42930858142#step:6:17)4:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/generate-mirror-repo-js/generate-mirror-repo-js/src/make/mirror.js'
  ]
}

Node.js v20.19.1

@fballiano
Copy link
Contributor Author

@rhoerr #216 should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants