Skip to content

1.3.1#297

Merged
fballiano merged 2 commits into
mage-os:mainfrom
fballiano:131
Sep 9, 2025
Merged

1.3.1#297
fballiano merged 2 commits into
mage-os:mainfrom
fballiano:131

Conversation

@fballiano
Copy link
Copy Markdown
Contributor

No description provided.

@fballiano fballiano requested a review from a team as a code owner September 9, 2025 14:10
@fballiano fballiano requested a review from rhoerr September 9, 2025 14:11
@fballiano
Copy link
Copy Markdown
Contributor Author

not sure why the test fails:

    ✕ supportedVersions for 2025-09-09T00:00:01Z (1 ms)

  ● getCurrentlySupportedVersions for mage-os › supportedVersions for 2025-09-09T00:00:01Z

    expect(received).toEqual(expected) // deep equality

    - Expected  - 0
    + Received  + 1

      Array [
    +   "mage-os/project-community-edition:1.3.0",
        "mage-os/project-community-edition:1.3.1",
      ]

      137 |             expect(
      138 |                 getCurrentlySupportedVersions(project, new Date(date))
    > 139 |             ).toEqual(result);
          |               ^
      140 |         }
      141 |     );
      142 | })

      at src/kind/get-currently-supported.spec.ts:139:15

since i've changed the dates

@fballiano
Copy link
Copy Markdown
Contributor Author

sorry, typo, everything is fixed now

Copy link
Copy Markdown
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fballiano fballiano merged commit c255b72 into mage-os:main Sep 9, 2025
9 of 75 checks passed
@fballiano fballiano deleted the 131 branch September 9, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants