fix(supported-version): handle semver-ish values from old magento ver…#309
Merged
fix(supported-version): handle semver-ish values from old magento ver…#309
Conversation
rhoerr
approved these changes
Dec 16, 2025
Contributor
rhoerr
left a comment
rhoerr
left a comment
There was a problem hiding this comment.
LGTM, thank you for the find and fix
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…isons
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when using "usable" you get an error like https://github.com/mage-os/generate-mirror-repo-js/actions/runs/20271742450/job/58212349808
Error: Invalid Version: 1. This is because the old Magento versions just label the composer versions as "1".Fixes: N/A
What is the new behavior?
We handle these old versions using
semver.coerceDoes this PR introduce a breaking change?
Other information