Skip to content

Conversation

@mzeis
Copy link
Member

@mzeis mzeis commented Jun 23, 2014

No description provided.

therouv added a commit that referenced this pull request Jun 23, 2014
@therouv therouv merged commit 2e49da3 into magento-hackathon:master Jun 23, 2014
@Vinai
Copy link
Member

Vinai commented Jun 23, 2014

No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.

Please fix. @therouv - please don't merge pakages that throw warnings during installation besides the "unbound version constraints (dev-master) should be avoided".

@paales
Copy link

paales commented Jun 23, 2014

I don't use it my self, but the license is OSL: https://github.com/ho-nl/Ho_Import#license

@mzeis mzeis deleted the patch-1 branch June 24, 2014 07:26
@Vinai
Copy link
Member

Vinai commented Jun 24, 2014

Please add it to the composer.json: https://github.com/ho-nl/Ho_Import/blob/master/composer.json

@paales
Copy link

paales commented Jun 25, 2014

Added the license to the composer.json

@therouv
Copy link
Member

therouv commented Jun 25, 2014

@paales In the README.md you defined "OSL" as license in the composer.json it's "GPL". Which one is correct? :)

@paales
Copy link

paales commented Jun 25, 2014

...I need to stop copy-pasting.. fixed

@therouv
Copy link
Member

therouv commented Jun 25, 2014

Perfect, thanks!

@Vinai
Copy link
Member

Vinai commented Jun 25, 2014

Thank you!

@mzeis
Copy link
Member Author

mzeis commented Jun 30, 2014

I think this issue can be closed.

@Vinai
Copy link
Member

Vinai commented Jun 30, 2014

It already is closed since the merge :)

@mzeis
Copy link
Member Author

mzeis commented Jun 30, 2014

Yikes. Of course. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants