Skip to content

Avoid installing magento-core in modman folder. #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2015
Merged

Avoid installing magento-core in modman folder. #184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a6f0c6
Avoid installing magento-core in modman folder.
nocturnalfrog Mar 9, 2015
b22f70b
adding debug info
nocturnalfrog Mar 9, 2015
8142c93
Revert "adding debug info"
nocturnalfrog Apr 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/MagentoHackathon/Composer/Magento/Installer/CoreInstaller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,24 @@ public function getDeployStrategy(PackageInterface $package, $strategy = null)
$deployStrategy->setIsForced($this->isForced);
return $deployStrategy;
}

/**
* Returns the installation path of a package
* We don't use the parent class for this because Magento Core should never be installed in the modman-root-dir
*
* @param PackageInterface $package
* @return string path
*/
public function getInstallPath(PackageInterface $package)
{
$targetDir = $package->getTargetDir();
$installPath = $this->getPackageBasePath($package) . ($targetDir ? '/'.$targetDir : '');

// Make install path absolute. This is needed in the symlink deploy strategies.
if (DIRECTORY_SEPARATOR !== $installPath[0] && $installPath[1] !== ':') {
$installPath = getcwd() . "/$installPath";
}

return $installPath;
}
}