Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@sta1r
Copy link
Contributor

@sta1r sta1r commented Jun 11, 2020

Purpose of this pull request

This PR adds an important caveat to the docs relating to session-based authentication for webapi endpoints, for logged-in admins.

Please refer to these two outstanding issues:

As you can see from the discussion here, this is a long-standing problem dating back to 2.1.x. Clearly, the docs outline how it should work, but seeing as it definitely does not, it's helpful to provide a note here to alert developers. Arguably there should be a more extensive rewrite with admin access moved to a 'pending functionality' section but that's beyond the remit of this contribution!

With any luck the fix is picked up soon and access works as expected.

Affected DevDocs pages

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@dobooth
Copy link
Contributor

dobooth commented Jun 11, 2020

running tests

@dobooth dobooth merged commit 438936f into magento:master Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

Hi @sta1r, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants