-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Example and links added for override layout section #8599
Example and links added for override layout section #8599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but there is comment about the company name in the example
|
|
||
| **Example:** | ||
|
|
||
| OrangeCo decided they should modify the product page layout completely to meet the new design, defined in `<Magento_Catalog_module_dir>/view/frontend/layout/catalog_product_view.xml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment here is that OrangeCo exists. Suggest using a name that doesn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BarnyShergold We need to use an imaginary company name that doesn't exist. Right?
If so, can we change the OrangeCo to something like SampleCompany?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work @ajithkumar-maragathavel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BarnyShergold I have updated the company name. Please review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
|
running tests |
|
Hi @ajithkumar-maragathavel, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) updates the example to the override layout section and provided the links to the override the layout page.
Affected DevDocs pages