Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@ajithkumar-maragathavel
Copy link
Contributor

Purpose of this pull request

This pull request (PR) updates the example to the override layout section and provided the links to the override the layout page.

Affected DevDocs pages

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but there is comment about the company name in the example


**Example:**

OrangeCo decided they should modify the product page layout completely to meet the new design, defined in `<Magento_Catalog_module_dir>/view/frontend/layout/catalog_product_view.xml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment here is that OrangeCo exists. Suggest using a name that doesn't?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BarnyShergold We need to use an imaginary company name that doesn't exist. Right?
If so, can we change the OrangeCo to something like SampleCompany?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work @ajithkumar-maragathavel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BarnyShergold I have updated the company name. Please review it.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@dobooth
Copy link
Contributor

dobooth commented Feb 5, 2021

running tests

@dobooth dobooth added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Technical Updates to the code or processes that alter the technical content of the doc labels Feb 5, 2021
@dobooth dobooth merged commit fe82ffb into magento:master Feb 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Partner: Ziffity partners-contribution PR created by Magento partner Progress: done Technical Updates to the code or processes that alter the technical content of the doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants