Skip to content

Conversation

@peterjaap
Copy link

See #736

@bohdan-harniuk bohdan-harniuk force-pushed the debug-step-filter-generation branch from c37d217 to c5a9441 Compare January 13, 2022 14:43
@bohdan-harniuk bohdan-harniuk changed the base branch from 4.2.0-develop to 4.3.0-develop January 13, 2022 14:43
@bohdan-harniuk
Copy link
Collaborator

Hello, @peterjaap!

Thank you for your work here!
I've changed base branch of this task to include this feature in the release 4.3.0.

I'll finish development here!
Sorry for so late response.

Regards,

@peterjaap
Copy link
Author

@bohdan-harniuk awesome!

@bohdan-harniuk
Copy link
Collaborator

Hello, @peterjaap!

Could you please help me?
I've checked this feature but it seems that it is not working.

My steps for testing:

  1. populated PHP > Debug > Step Filters > Files with files for testing (manually)
  2. populated PHP > Debug > Skipped Paths with files for testing (manually)
  3. set up breakpoints
  4. started debugging
  5. the debugger went into the files that should have been skipped

As I understood, those files should be skipped during debugging. One of the files that was added into skipped, had breakpoint, another didn't.

Thank you in advance.

@peterjaap
Copy link
Author

@bohdan-harniuk can you provide some screenshots of your configuration?

@bohdan-harniuk
Copy link
Collaborator

Hello, @peterjaap!

Yes, of course.

Screenshot 2022-01-21 at 09 33 34

Screenshot 2022-01-21 at 09 33 25

@peterjaap
Copy link
Author

peterjaap commented Jan 21, 2022

@bohdan-harniuk are you running PHP locally in a Docker container? In that case the absolute paths might not be correct. Maybe you can try using relative paths?

@bohdan-harniuk
Copy link
Collaborator

@peterjaap, it doesn't work for me with relative paths. Would be great if you can show me how it works for you, or wise versa, I can show you what doesn't work for me.

@bohdan-harniuk bohdan-harniuk linked an issue Jan 31, 2022 that may be closed by this pull request
@bohdan-harniuk
Copy link
Collaborator

@peterjaap, any updates here?

Regards,

@bohdan-harniuk
Copy link
Collaborator

Hello, @peterjaap!

Please, assist us with this issue.
I really want to include this into the upcoming release.
Without your help, we cannot go farther.

Regards,

@peterjaap
Copy link
Author

Ok let's retrace a bit. What exactly do you mean when you say

I've checked this feature but it seems that it is not working.

The whole step debug filter feature in PhpStorm isn't working? At all? Because then that sounds more like a PhpStorm issue than anything else. I've used the step debug filter a bunch of times, though not recently so maybe something broke in a recent version? You might check their issue tracker to see if anyone mentioned it.

@bohdan-harniuk
Copy link
Collaborator

@peterjaap, I'm more tends to think that I misconfigured something or misunderstood how it should work.

I left breakpoint in that files that I added to the Step Filters and to the Skipped Paths.
I was expecting that debugger will ignore them, but it wasn't.
Also I have checked if step into will open those files and it was so, but I guess It should not.

Could you please check my thoughts?

Regards,

@bohdan-harniuk
Copy link
Collaborator

On hold. Not reproducible, no response.

Can be reopened only with the reporter assistance.

@peterjaap
Copy link
Author

This bug is still open; https://youtrack.jetbrains.com/issue/WI-43194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate PHP (X)debug Step Filter configuration

2 participants