Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fixed the welcome message contains single quote character #35481

Closed
5 tasks
m2-assistant bot opened this issue May 16, 2022 · 2 comments · Fixed by #34061
Closed
5 tasks

[Issue] Fixed the welcome message contains single quote character #35481

m2-assistant bot opened this issue May 16, 2022 · 2 comments · Fixed by #34061
Labels
Area: Account Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented May 16, 2022

This issue is automatically created based on existing pull request: #34061: Fixed the welcome message contains single quote character


Description (*)

This PR is fixed for the issue, that if we put the single quote character to the header welcome message config, it will lead the frontend to have a bunch of console errors:

Uncaught SyntaxError: Unable to process binding "ifnot: function(){return customer().fullname }"
Message: Unable to parse bindings.

Manual testing scenarios (*)

  1. From Admin, navigate to Content -> Design -> Configuration
  2. Select a theme and Edit
  3. In the edit page, expand the Header setting, put the Welcome Text, like "Welcome Khoi's store!"
  4. Clear cache, then go to frontend, you'll see a JS error, and some JS functions not working because of this issue.

Questions or comments

Maybe we need to bind the message as a text, instead of HTML binding, like:

data-bind="text: 'escapeHtmlAttr($welcomeMessage) ?>'"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Theme Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels May 16, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog May 16, 2022
@engcom-Lima engcom-Lima added Area: Admin UI Area: Catalog Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 16, 2022
@engcom-Alfa engcom-Alfa added Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Area: Admin UI Area: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 16, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-3121 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented May 20, 2022

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants