Fixed the welcome message contains single quote character #34061

khoimm92 · 2021-09-12T12:25:30Z

Description (*)

This PR is fixed for the issue, that if we put the single quote character to the header welcome message config, it will lead the frontend to have a bunch of console errors:

Uncaught SyntaxError: Unable to process binding "ifnot: function(){return customer().fullname }"
Message: Unable to parse bindings.

Manual testing scenarios (*)

From Admin, navigate to Content -> Design -> Configuration
Select a theme and Edit
In the edit page, expand the Header setting, put the Welcome Text, like "Welcome Khoi's store!"
Clear cache, then go to frontend, you'll see a JS error, and some JS functions not working because of this issue.

Questions or comments

Maybe we need to bind the message as a text, instead of HTML binding, like:

data-bind="text: 'escapeHtmlAttr($welcomeMessage) ?>'"

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fixed the welcome message contains single quote character #35481: Fixed the welcome message contains single quote character

m2-assistant · 2021-09-12T12:25:32Z

Hi @khoimm92. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

khoimm92 · 2021-09-12T12:28:47Z

@magento run all tests

magento-automated-testing · 2021-09-12T12:28:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…uote-character

mrtuvn · 2021-09-14T02:39:45Z

imho should be text in that point

BarnyShergold · 2021-09-16T08:58:23Z

@magento run all tests

magento-automated-testing · 2021-09-16T08:58:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-09-16T08:59:01Z

@khoimm92 - You need to sign the Adobe CLA as part of this PR review - you only ever need to do this once.

khoimm92 · 2021-09-17T01:06:50Z

@magento run all tests

magento-automated-testing · 2021-09-17T01:06:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-09-17T08:52:30Z

@magento run Static Tests

magento-automated-testing · 2021-09-17T08:52:38Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-09-20T09:18:01Z

@khoimm92 - You will need to fix the Static test on this - not sure why they passed before!

BarnyShergold · 2021-09-21T09:20:05Z

@khoimm92 - You also need to sign the Adobe CLA

…uote-character

BarnyShergold · 2021-09-23T13:43:03Z

@magento run all tests

magento-automated-testing · 2021-09-23T13:43:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

@khoimm92 Please fix failed static tests

mrtuvn · 2021-09-24T16:01:56Z

html not allowed
So in my opinion don't need to bind as html

khoimm92 · 2021-09-24T16:43:00Z

Thanks @mrtuvn, let me change that.
@BarnyShergold @Den4ik I got it. Also, my fix did not cover the case putting the double quote. Let me have a tweak for this.

BarnyShergold · 2021-10-07T14:23:05Z

@khoimm92 - We've not had an update or change on this PR for 2 weeks. Can you let us know when you will complete changes or we'll have to close the PR for inactivity - cheers

magento-automated-testing · 2022-05-30T13:35:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-05-30T13:38:54Z

Fixed the build failure. Implemented the fix for unit test and pushed the code for the same.

Moving it to Testing now.

Thank you!

engcom-Alfa · 2022-05-31T06:25:22Z

@magento run Functional Tests EE, Integration Tests, Semantic Version Checker

magento-automated-testing · 2022-05-31T06:25:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-06-01T06:29:17Z

@magento run Semantic Version Checker

magento-automated-testing · 2022-06-01T06:29:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-06-01T07:42:49Z

@magento run Semantic Version Checker

magento-automated-testing · 2022-06-01T07:42:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-06-01T09:56:50Z

Tested this PR, working fine but Semantic Version Checker is failed. Hence, raising JIRA approval for svc failure.

engcom-Charlie · 2022-08-08T11:56:49Z

It seems that bot moved the PR from Pending Approval to Changes Requested. Moving it back.

Thank you!

Fixed the Welcome message contains single quote character

ba36a5a

magento-engcom-team added Area: Frontend Component: Theme Release Line: 2.4 labels Sep 12, 2021

Merge branch '2.4-develop' into fix-welcome-message-contains-single-q…

c51fa95

…uote-character

BarnyShergold self-assigned this Sep 17, 2021

m2-community-project bot added the Progress: review label Sep 17, 2021

Merge branch '2.4-develop' into fix-welcome-message-contains-single-q…

1b7e347

…uote-character

Den4ik requested changes Sep 24, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Sep 24, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Sep 24, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels May 30, 2022

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jun 1, 2022

m2-community-project bot added Progress: to approve Progress: pending approval and removed Progress: testing in progress Progress: to approve labels Jun 1, 2022

engcom-Lima added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Aug 8, 2022

m2-community-project bot added Progress: needs update and removed Progress: pending approval labels Aug 8, 2022

m2-community-project bot added Progress: pending approval Progress: accept and removed Progress: needs update Progress: pending approval labels Aug 8, 2022

magento-devops-reposync-svc merged commit a57d60c into magento:2.4-develop Aug 31, 2022

khoimm92 deleted the fix-welcome-message-contains-single-quote-character branch August 31, 2022 07:49

khoimm92 restored the fix-welcome-message-contains-single-quote-character branch August 31, 2022 07:51

khoimm92 deleted the fix-welcome-message-contains-single-quote-character branch August 31, 2022 07:51

khoimm92 restored the fix-welcome-message-contains-single-quote-character branch August 31, 2022 07:59

Fixed the welcome message contains single quote character #34061

Fixed the welcome message contains single quote character #34061

Uh oh!

Conversation

khoimm92 commented Sep 12, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Sep 12, 2021

Uh oh!

khoimm92 commented Sep 12, 2021

Uh oh!

magento-automated-testing bot commented Sep 12, 2021

Uh oh!

mrtuvn commented Sep 14, 2021

Uh oh!

BarnyShergold commented Sep 16, 2021

Uh oh!

magento-automated-testing bot commented Sep 16, 2021

Uh oh!

BarnyShergold commented Sep 16, 2021

Uh oh!

khoimm92 commented Sep 17, 2021

Uh oh!

magento-automated-testing bot commented Sep 17, 2021

Uh oh!

BarnyShergold commented Sep 17, 2021

Uh oh!

magento-automated-testing bot commented Sep 17, 2021

Uh oh!

BarnyShergold commented Sep 20, 2021

Uh oh!

BarnyShergold commented Sep 21, 2021

Uh oh!

BarnyShergold commented Sep 23, 2021

Uh oh!

magento-automated-testing bot commented Sep 23, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

mrtuvn commented Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khoimm92 commented Sep 24, 2021

Uh oh!

BarnyShergold commented Oct 7, 2021

Uh oh!

magento-automated-testing bot commented May 30, 2022

Uh oh!

engcom-Charlie commented May 30, 2022

Uh oh!

engcom-Alfa commented May 31, 2022

Uh oh!

magento-automated-testing bot commented May 31, 2022

Uh oh!

engcom-Lima commented Jun 1, 2022

Uh oh!

magento-automated-testing bot commented Jun 1, 2022

Uh oh!

engcom-Lima commented Jun 1, 2022

Uh oh!

magento-automated-testing bot commented Jun 1, 2022

Uh oh!

engcom-Lima commented Jun 1, 2022

Uh oh!

engcom-Charlie commented Aug 8, 2022

Uh oh!

Uh oh!

khoimm92 commented Sep 12, 2021 •

edited by m2-assistant bot

Loading

mrtuvn commented Sep 24, 2021 •

edited

Loading