Fixed TypeError when search term does not exist on pressing Home or End button #14274 #14301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this._getFirstVisibleElement()
returns false if there are no elements in the search autocomplete. I added check ifthis._getFirstVisibleElement()
does not returnfalse
before adding select class to the first element when Home or End buttons on keyboard are pressed.Fixed Issues (if relevant)
#14274: Quick search fires error
Manual testing scenarios
1.Type a term into the quick Ajax search field (#search) that doesn't exist in the database
2. Press Home or End keyboard key
3. No TypeError: this._getFirstVisibleElement(...).addClass is not a function
Contribution checklist