Fixes in widget component (2.3-develop) #15554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR @mhauri . Let me take a look over it now for you. |
|
Hi @dmanners I "fixed" the failing static tests. |
|
Hi @mhauri. Thank you for your contribution. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues in the Magento/Widget Component:
Adding missing properties which are assigned in the
_construct()on line 177 and 178Fix class reference to a non-existent class in the tests. See on line 55 in
Magento/Widget/Test/Unit/Model/_files/widget_config.phpand line 44 inMagento/Widget/Test/Unit/Model/_files/widget.xmlContribution checklist