Skip to content

Fixes in widget component (2.3-develop) #15554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2018
Merged

Fixes in widget component (2.3-develop) #15554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0c157e
[fix] add missing properties
May 28, 2018
7e69251
[fix] reference to invalid class Magento\Backend\Block\Catalog\Produc…
May 28, 2018
e1c0fa9
[fix] widget.xml to match fixed class reference
May 28, 2018
65d72bb
[task] add SuppressWarnings(PHPMD.TooManyFields)
May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/code/Magento/Widget/Model/Widget/Instance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* @method int getThemeId()
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.TooManyFields)
* @since 100.0.2
*/
class Instance extends \Magento\Framework\Model\AbstractModel
Expand Down Expand Up @@ -96,6 +97,16 @@ class Instance extends \Magento\Framework\Model\AbstractModel
*/
protected $_relatedCacheTypes;

/**
* @var \Magento\Catalog\Model\Product\Type
*/
protected $_productType;

/**
* @var \Magento\Widget\Model\Config\Reader
*/
protected $_reader;

/**
* @var \Magento\Framework\Escaper
*/
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Widget/Test/Unit/Model/_files/widget.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
</parameter>
<parameter name="id_path" xsi:type="block" visible="true" required="true" sort_order="10">
<label translate="true">Product</label>
<block class="Magento\Backend\Block\Catalog\Product\Widget\Chooser">
<block class="Magento\Catalog\Block\Adminhtml\Product\Widget\Chooser">
<data>
<item name="button" xsi:type="array">
<item name="open" xsi:type="string" translate="true">Select Product...</item>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Widget/Test/Unit/Model/_files/widget_config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
'type' => 'label',
'@' => ['type' => 'complex'],
'helper_block' => [
'type' => \Magento\Backend\Block\Catalog\Product\Widget\Chooser::class,
'type' => \Magento\Catalog\Block\Adminhtml\Product\Widget\Chooser::class,
'data' => ['button' => ['open' => 'Select Product...']],
],
'visible' => '1',
Expand Down