Skip to content

[Forwardport] Fixing the address checkbox being unchecked on payment step. #17628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2018
Merged

[Forwardport] Fixing the address checkbox being unchecked on payment step. #17628

merged 1 commit into from
Sep 13, 2018

Conversation

jignesh-baldha
Copy link
Member

Original Pull Request

#17593

Description

When an offline custom payment method is used, the 'My billing and shipping address are the same' checkbox from payment step is unchecked, if the shipping address is updated.

Please check the issue's description for more details.

Fixed Issues (if relevant)

  1. Custom Payment Method doesn't uncheck 'My billing and shipping address are the same' #14819: Custom Payment Method doesn't uncheck 'My billing and shipping address are the same'

Manual testing scenarios

  1. Create an offline payment method
  2. Add a product to cart
  3. Go to Checkout
  4. Fill in the shipping address
  5. Go to Payment Step
  6. We have our new payment method, and one more - Checkmo
  7. Select Checkmo
  8. Under Selected Payment Method - My billing and shipping address are the same is checked and below we have the billing address = shipping address
    4d0833cc22
  9. Go back to shipping step and change some fields
  10. Come back on the Payment Step

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 15, 2018

Hi @jignesh-baldha , I'm closing this PR as a duplicate for #17617.
Thank you!

@sidolov sidolov closed this Aug 15, 2018
@jignesh-baldha
Copy link
Member Author

jignesh-baldha commented Aug 16, 2018

@sidolov PR #17617 is already closed. Or please move #17593 to Port to 2.3 Created in Ports Wanted

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants