Skip to content

Conversation

akshayadixit
Copy link
Contributor

@akshayadixit akshayadixit commented Dec 14, 2018

Typo taax -> tax

Minor Typo taax -> tax

Description (*)

Minor Typo taax -> tax

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Typo taax -> tax
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 14, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @akshayadixit. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-3692 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@akshayadixit thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 5a844e6 into magento:2.3-develop Dec 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @akshayadixit. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team
Copy link
Contributor

Hi @akshayadixit. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@milindsingh milindsingh mentioned this pull request Dec 26, 2018
4 tasks
@akshayadixit akshayadixit deleted the 2.3-develop-typo-fix branch January 16, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants