Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3 develop ddevesh typos fixed #20039

Conversation

ddevesh
Copy link
Member

@ddevesh ddevesh commented Jan 2, 2019

Description (*)

Fixed Issues (if relevant)

1.typos error fixed in files -
Typo in Comments:
app/code/Magento/Catalog/view/adminhtml/web/catalog/product/composite/configure.js@115 expamle -> example
app/code/Magento/Catalog/view/base/web/js/price-utils.js@63 trailig -> trailing
app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php@325 Rerieve -> Retrieve

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Multiple use of expamle rather than "example" .
trailig was used rather than trailing in line number 63
typo error fixed at line number 325 where " Rerieve " was used rather than "Retrieve",
@magento-engcom-team
Copy link
Contributor

Hi @ddevesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 2, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddevesh for your contribution!

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-3806 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@ddevesh thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit fd1a404 into magento:2.3-develop Jan 16, 2019
@ghost
Copy link

ghost commented Jan 16, 2019

Hi @ddevesh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @ddevesh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants