Skip to content

Typo Fixed in code. #20059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2019
Merged

Typo Fixed in code. #20059

merged 4 commits into from
Jan 31, 2019

Conversation

realadityayadav
Copy link
Member

@realadityayadav realadityayadav commented Jan 3, 2019 •
edited
Loading

Description (*)

Fixed Issues (if relevant)

  1. Fixed Typo of $extensionAttrbutes -> $extensionAttributes
    FILE - app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php
  2. Fixed Typo of WigetTabs -> WidgetTabs
    FILE - app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tabs.php

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @adityayadav-cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@realadityayadav realadityayadav changed the title 2.3 develop adityayadav cedcoss patch 1 Typo Fixed in code. Jan 3, 2019
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nuzil nuzil self-requested a review January 3, 2019 15:06
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3785 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@adityayadav-cedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

nuzil
nuzil requested changes Jan 4, 2019
View reviewed changes
app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php
@@ -180,7 +180,7 @@ class ProductTest extends \PHPUnit\Framework\TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
private $extensionAttrbutes;
private $extensionAttributes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check Unit Tests, such variable is already presented in codebase

@realadityayadav
Copy link
Member Author

Sure @nuzil I am on it.

@nuzil
Copy link
Contributor

nuzil commented Jan 7, 2019

@adityayadav-cedcoss were those tests you changed broken before? Or how this change is related to Typo's fix?

@realadityayadav
Copy link
Member Author

@nuzil There were typos that I have found and addressed but the test failed due to duplication of the variable name in my first commit.
The 2nd set of changes that I committed fixed the duplication error as well as typo's.

p-bystritsky
p-bystritsky reviewed Jan 8, 2019
View reviewed changes
p-bystritsky
p-bystritsky suggested changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@p-bystritsky p-bystritsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityayadav-cedcoss, please edit testGetCategoryIdWhenProductNotInCurrentCategory test. Now it's failing.

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit 19291aa into magento:2.3-develop Jan 31, 2019
@ghost
Copy link

ghost commented Jan 31, 2019

Hi @adityayadav-cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2019
@sidolov
ENGCOM-3785: Typo Fixed in code. #20059
c593019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil requested changes

+2 more reviewers

@milindsingh milindsingh milindsingh left review comments

@p-bystritsky p-bystritsky p-bystritsky requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nuzil nuzil

Labels
Cleanup Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
7 participants
@realadityayadav @magento-engcom-team @magento-cicd2 @nuzil @milindsingh @p-bystritsky @okorshenko