Skip to content

Apply-discount-code-placeholder-get-cut ::Apply discount code placeho… #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ajay2jcommerce
Copy link

…lder gets cut in Tab portriat view on cart page

Description (*)

Fixed Issues (if relevant)

  1. fixed issue Apply discount code placeholder gets cut in Tab portriat view on cart page #20278: Apply discount code placeholder gets cut in Tab portriat view on cart page

Manual testing scenarios (*)

  1. Add product in shopping cart
  2. Goto cart page
  3. Click on "Apply Discount Code"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…lder gets cut in Tab portriat view on cart page
@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@@ -694,6 +694,9 @@
position: static;
}
}
&.discount{
width:auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ajay2jcommerce. Thanks for collaboration. Can you explain why do you use width:auto if its default value of width property?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets

In default magento 2.3.0 when using width: 48% issue still getting generate. When use width:auto issue get fixed reason using that property.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajay2jcommerce ok, thanks

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3901 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @ajay2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants