Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed-Apply-discount-code-placeholder-2.2 #20586

Conversation

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Jan 24, 2019

Description (*)

#20278

Fixed Issues (if relevant)

  1. Apply-discount-code-placeholder-get-cut in Tab portriat view on cart page
  2. Magento 2.2

Manual testing scenarios (*)

  1. Add product in shopping cart
  2. Goto cart page
  3. Click on "Apply Discount Code"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #20281

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jan 24, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mage2pratik mage2pratik self-assigned this Jan 25, 2019
@mage2pratik mage2pratik changed the title Fixed-Apply-discount-code-placeholder-2.2 [Backport] Fixed-Apply-discount-code-placeholder-2.2 Jan 25, 2019
@amol2jcommerce

This comment has been minimized.

Copy link
Contributor Author

amol2jcommerce commented Jan 30, 2019

Hi @magento-engcom-team please review.

@amol2jcommerce

This comment has been minimized.

Copy link
Contributor Author

amol2jcommerce commented Feb 3, 2019

@magento-engcom-team please review.

@sidolov
sidolov approved these changes Feb 4, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 4, 2019

Hi @sidolov, thank you for the review.
ENGCOM-4123 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit f2d28ed into magento:2.2-develop Feb 8, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 8, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 8, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.