Skip to content

Conversation

sasangagamlath
Copy link
Contributor

Description (*)

Remove unused reference on wishlist fromcart controller
app/code/Magento/Wishlist/Controller/Index/Fromcart.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sasangagamlath. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 11, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Component: Wishlist Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 11, 2019
@sasangagamlath sasangagamlath changed the title Remove unused reference on wishlist fromcart controller Remove unused reference on wishlist Fromcart controller Feb 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sasangagamlath
Thank you for your contribution. This pull request has been combined (merged) with #21129 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

@ghost
Copy link

ghost commented Feb 11, 2019

Hi @sasangagamlath, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Wishlist Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants