New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused reference on wishlist ConvertSerializedData controller #21129

Merged
merged 3 commits into from Feb 13, 2019

Conversation

@sasangagamlath
Copy link
Contributor

sasangagamlath commented Feb 11, 2019

Remove unused reference on wishlist ConvertSerializedData controller
/app/code/Magento/Wishlist/Setup/Patch/Data/ConvertSerializedData.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @sasangagamlath. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

magento-cicd2 commented Feb 11, 2019

CLA assistant check
All committers have signed the CLA.

@sasangagamlath sasangagamlath changed the title Remove unused reference on wishlist convert serialized data controller Remove unused reference on wishlist ConvertSerializedData controller Feb 11, 2019

@sidolov

This comment has been minimized.

Copy link
Contributor

sidolov commented Feb 11, 2019

@magento-engcom-team combine 21127

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

@sasangagamlath all pull requests have been successfully combined together:

  • merged #21127: Remove unused reference on wishlist Fromcart controller
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @sidolov, thank you for the review.
ENGCOM-4214 has been created to process this Pull Request

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

@sasangagamlath thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team moved this from TODO to Testing In Progress in Community Pull Requests Feb 11, 2019

@magento-engcom-team magento-engcom-team moved this from Testing In Progress to Merging In Progress in Community Pull Requests Feb 12, 2019

@magento-engcom-team magento-engcom-team merged commit 37c6ae3 into magento:2.3-develop Feb 13, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 13, 2019

Hi @sasangagamlath, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Community Pull Requests automation moved this from Merging In Progress to Done Feb 13, 2019

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019

@sidolov sidolov added this to the Release: 2.3.2 milestone Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment