Skip to content

Add number validation for sitemap file limits #24358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2019
Merged

Add number validation for sitemap file limits #24358

merged 3 commits into from
Sep 5, 2019

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Aug 29, 2019 •
edited
Loading

Description (*)

Add number validation for sitemap file limits

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: N/A

Manual testing scenarios (*)

  1. Go to admin area
  2. Go to Stores -> Configuration -> Catalog -> XML Sitemap -> Sitemap File Limits
  3. Edit Maximum No of URLs Per File and Maximum File Size
  4. Save the config

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 29, 2019

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned VladimirZaets Aug 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5731 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Aug 30, 2019
@engcom-Alfa
Copy link
Contributor

Hi @ravi-chandra3197, we can still use negative numbers. (-10 for ex.) This is incorrect validation.

Could you take a look, please?

Thanks!

oleksii-lisovyi
oleksii-lisovyi reviewed Aug 30, 2019
View reviewed changes
app/code/Magento/Sitemap/etc/adminhtml/system.xml Outdated
@@ -83,10 +83,12 @@
<label>Sitemap File Limits</label>
<field id="max_lines" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Maximum No of URLs Per File</label>
<validate>validate-number</validate>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another validation class "validate-greater-than-zero", that should fix the problem with values below or equal to zero.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added validation for greater than zero

@ravi-chandra3197
Copy link
Contributor Author

Hi @ravi-chandra3197, we can still use negative numbers. (-10 for ex.) This is incorrect validation.

Could you take a look, please?

Thanks!

Hello @engcom-Alfa
I have update PR can you check it.

@ghost ghost assigned sidolov Sep 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5731 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 5, 2019
magento-engcom-team pushed a commit that referenced this pull request Sep 5, 2019
@sidolov
ENGCOM-5731: Add number validation for sitemap file limits #24358
846a669
@magento-engcom-team magento-engcom-team merged commit 817a58a into magento:2.3-develop Sep 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 5, 2019
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

+1 more reviewer

@oleksii-lisovyi oleksii-lisovyi oleksii-lisovyi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Sitemap Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@ravi-chandra3197 @magento-engcom-team @engcom-Alfa @oleksii-lisovyi @VladimirZaets @sidolov @engcom-Foxtrot