Skip to content

Add number validation for sitemap file limits #24358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Add number validation for sitemap file limits #24358

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfdb152
add number validation for sitemap file limits
ravi-chandra3197 Aug 29, 2019
6aad823
Add validation greater than zero
ravi-chandra3197 Aug 30, 2019
817a58a
Removed extra whitespaces from the configuration
sidolov Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/code/Magento/Sitemap/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,12 @@
<label>Sitemap File Limits</label>
<field id="max_lines" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Maximum No of URLs Per File</label>
<validate>validate-number validate-greater-than-zero</validate>
</field>
<field id="max_file_size" translate="label comment" type="text" sortOrder="2" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Maximum File Size</label>
<comment>File size in bytes.</comment>
<validate>validate-number validate-greater-than-zero</validate>
</field>
</group>
<group id="search_engines" translate="label" type="text" sortOrder="6" showInDefault="1" showInWebsite="1" showInStore="1">
Expand Down