Skip to content

change shopping cart to minicart #24411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2019
Merged

change shopping cart to minicart #24411

merged 4 commits into from
Sep 12, 2019

Conversation

sunilit42
Copy link
Contributor

Fixed issue :- #24409

@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2019

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@XxXgeoXxX XxXgeoXxX self-requested a review September 3, 2019 05:07
XxXgeoXxX
XxXgeoXxX requested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@XxXgeoXxX XxXgeoXxX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magento has a lot of additional entities that relevant to this label.
We could not change this label only in one place and skip others.
Please, recheck and update translations, MFTF tests, comment, etc to prevent misunderstanding.

@ghost ghost assigned XxXgeoXxX Sep 3, 2019
@sunilit42
Copy link
Contributor Author

@XxXgeoXxX

thanks for the review .

I did into translate csv file and I checked into test folder nothing related to this.

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX, thank you for the review.
ENGCOM-5752 has been created to process this Pull Request
✳️ @XxXgeoXxX, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Sep 4, 2019
@engcom-Delta
Copy link
Contributor

Hi @sunilit42 There are left few occurrences of "Shopping Cart Sidebar" in the comments:
image

Could you take a look?

@sunilit42 sunilit42 requested a review from paliarush as a code owner September 6, 2019 09:47
@sunilit42
Copy link
Contributor Author

Hi @sunilit42 There are left few occurrences of "Shopping Cart Sidebar" in the comments:
image

Could you take a look?

I did please check it, I did not do for one file because it is related to admin shopping cart

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX, thank you for the review.
ENGCOM-5752 has been created to process this Pull Request
✳️ @XxXgeoXxX, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 10, 2019
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team mentioned this pull request Sep 12, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Sep 12, 2019
@sidolov
ENGCOM-5752: change shopping cart to minicart #24411
ae350b6
@magento-engcom-team magento-engcom-team merged commit 6b3c12e into magento:2.3-develop Sep 12, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2019

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 12, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XxXgeoXxX XxXgeoXxX XxXgeoXxX approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@XxXgeoXxX XxXgeoXxX

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@sunilit42 @magento-engcom-team @engcom-Delta @engcom-Foxtrot @XxXgeoXxX @sidolov @p-bystritsky