Skip to content

change shopping cart to minicart #24411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2019
Merged

change shopping cart to minicart #24411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95cad1a
change shopping cart to minicart
sunilit42 Sep 2, 2019
29a1544
change label into transate csv
sunilit42 Sep 3, 2019
bc1657b
change word shopping cart to mini cart
sunilit42 Sep 6, 2019
6b3c12e
Merge remote-tracking branch 'mainline/2.3-develop' into checkout-tex…
p-bystritsky Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tf/Test/StorefrontAddBundleDynamicProductToShoppingCartWithDisableMiniCartSidebarTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<argument name="total" value="110.00"/>
</actionGroup>

<!--Enabled Shopping Cart Sidebar -->
<!--Enabled Mini Cart -->
<magentoCLI stepKey="enableShoppingCartSidebar" command="config:set checkout/sidebar/display 1"/>
<magentoCLI command="cache:flush" stepKey="flushCache"/>
<reloadPage stepKey="reloadThePage"/>
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Checkout/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@
</field>
</group>
<group id="sidebar" translate="label" sortOrder="4" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Shopping Cart Sidebar</label>
<label>Mini Cart</label>
<field id="display" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Display Shopping Cart Sidebar</label>
<label>Display Mini Cart</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
</field>
<field id="count" translate="label" type="text" sortOrder="2" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Checkout/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ Shipping,Shipping
"Number of Items to Display Pager","Number of Items to Display Pager"
"My Cart Link","My Cart Link"
"Display Cart Summary","Display Cart Summary"
"Shopping Cart Sidebar","Shopping Cart Sidebar"
"Display Shopping Cart Sidebar","Display Shopping Cart Sidebar"
"Mini Cart","Mini Cart"
"Display Mini Cart","Display Mini Cart"
"Number of Items to Display Scrollbar","Number of Items to Display Scrollbar"
"Maximum Number of Items to Display","Maximum Number of Items to Display"
"Payment Failed Emails","Payment Failed Emails"
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/Magento/blank/web/css/source/_extends.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,7 +1290,7 @@
}

//
// Shopping cart sidebar and checkout sidebar totals
// Mini Cart and checkout sidebar totals
// ---------------------------------------------

& when (@media-common = true) {
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/Magento/luma/web/css/source/_extends.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1713,7 +1713,7 @@
}

//
// Shopping cart sidebar and checkout sidebar totals
// Mini Cart and checkout sidebar totals
// ---------------------------------------------

& when (@media-common = true) {
Expand Down