Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CliIndexerReindexActionGroup action group usage for Sales module #31788

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Removed CliIndexerReindexActionGroup action group usage for Sales module #31788

merged 1 commit into from
Feb 5, 2021

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 20, 2021 •
edited by m2-assistant bot
Loading

Description

Remove CliIndexerReindexActionGroup action group usage from tests to improve execution time for Sales, SalesRule, Search, Store and Swatches modules.

Resolved issues:

  1. resolves [Issue] Removed CliIndexerReindexActionGroup action group usage for Sales module #31801: Removed CliIndexerReindexActionGroup action group usage for Sales module

@sergiy-v
Removed usage or changed value of CliIndexerReindexActionGroup action…
9dd746a 
… group for Sales, SalesRule, Search, Store, Swatches modules
@m2-assistant
Copy link

m2-assistant bot commented Jan 20, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests B2B

@rogyar rogyar self-assigned this Jan 21, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Jan 21, 2021
@rogyar
Copy link
Contributor

rogyar commented Jan 21, 2021

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 21, 2021
Closed
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 21, 2021
rogyar
rogyar approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Jan 21, 2021
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8681 has been created to process this Pull Request

@sergiy-v
Copy link
Contributor Author

@magento run all tests

@rogyar rogyar added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 31, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Jan 31, 2021
@engcom-Delta engcom-Delta self-assigned this Feb 1, 2021
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 1, 2021
@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Feb 1, 2021
magento-engcom-team pushed a commit that referenced this pull request Feb 5, 2021
@gabrieldagama
ENGCOM-8681: Removed CliIndexerReindexActionGroup action group usage …
7921a36 
…for Sales module #31788
@magento-engcom-team magento-engcom-team merged commit 930b789 into magento:2.4-develop Feb 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Component: SalesRule Component: Search Component: Store Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliIndexerReindexActionGroup action group usage for Sales module
5 participants
@sergiy-v @rogyar @magento-engcom-team @engcom-Delta @gabrieldagama