cart api bug fix & partial invoice credit memo divide by zero warning #327

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@destination-experience

Sorry i didnt realize committing here would add the change to the pull request. There are two issuses here now. Let me know if you want me to try and sort them apart.

The cart api doesnt properly save a price when shoppingCartProductAdd() is called. The reason is because no addresses are stored for the quote. This fixes that by adding a call to getBillingAddress() and getShippingAddress() in shoppingCartCreate().

If you have an order with multiple items on it and invoice just one of those items. Then, trying to create a credit memo for that order causes a divide by zero warning in two different files. The issue here is that the credit memo assumes all the items have been invoiced. I created a fix by just checking the number of invoiced items.

@verklov

This comment has been minimized.

Show comment Hide comment
@verklov

verklov Nov 7, 2013

Contributor

Hello destination-experience,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

Contributor

verklov commented Nov 7, 2013

Hello destination-experience,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

magento-team added a commit that referenced this pull request Nov 29, 2013

2.0.0.0-dev54
* Modularity improvements:
  * Breakdown of the Adminhtml module:
     * Moved Newsletter, Report logic to the respective modules
     * Moved blocks, config, view, layout files of other components from Adminhtml folder to respective modules
  * Removed application dependencies from the library
* Move Magento\Core common blocks in the library
* Application areas rework:
  * Areas are independent from Store
  * Removed deprecated annotation from the getArea methods
* GitHub requests:
  * [#245](#245) -- Resolve design flaws in core URL helper
  * [#247](#247) -- Bug in Mage_Page_Block_Html_Header->getIsHomePage
  * [#259](#259) -- Turkish Lira (TRY) is supported for Turkish members.
  * [#262](#262) -- Update Rule.php
  * [#373](#373) -- [Magento/Sales] Fixed typos
  * [#382](#382) -- [Magento/Core] Fixed typos
  * [#304](#304) -- Removed Erroneous closing "
  * [#323](#323) -- InstanceController.php - made setBody protected
  * [#349](#349) -- Move Mage_Catalog menu declaration into Mage_Catalog module.
  * [#265](#265) -- Update Merge.php
  * [#271](#271) -- Check Data should validate gallery information
  * [#305](#305) -- Extra ", tidied up nested quotes
  * [#352](#352) -- Add Croatia Country as part of European Union since 1st July 2013 for default european local countries in configuration
  * [#224](#224) -- Tax formatting is locale aware and should not
  * [#338](#338) -- Correcting SQL for required_options column
  * [#327](#327) -- cart api bug fix & partial invoice credit memo divide by zero warning
* Themes update:
  * Old frontend (magento_demo) and backend (magento_basic) themes are removed
  * Updated templates and layout updates in the Bundle, Catalog, CatalogInventory, CatalogSearch, Downloadable, ProductAlert, Reports, Sendfriend modules
* Fixed bugs:
  * Fixed the error when  Magento cannot be reinstalled to the same database with table prefix
  * Fixed report Products in Cart
  * Fixed error on attempt to insert image to CMS pages under version control
  * Fixed order status grid so that you can assign state, edit, and view custom order status
  * Fixed Related Products Rule page so that category can be selected on conditions tab
  * Fixed Magento_Paypal_Controller_ExpressTest integration test so it is re-enabled
  * Fixed the bug with international DHL quotes
@elenleonova

This comment has been minimized.

Show comment Hide comment
@elenleonova

elenleonova Nov 29, 2013

destination-experience,
We have processed your pull request. The code is released in version dev54.
Huge thanks for your contribution!

destination-experience,
We have processed your pull request. The code is released in version dev54.
Huge thanks for your contribution!

magento-team pushed a commit that referenced this pull request May 29, 2015

magento-team pushed a commit that referenced this pull request Jan 20, 2016

Merge pull request #327 from magento-api/indexer
[PHP7 Indexer]: Remi PHP 7.0.1 failure on L1 segmentation fault on SOAP / REST

okorshenko pushed a commit that referenced this pull request Dec 14, 2016

Merge pull request #327 from magento-performance/MAGETWO-57905
Story:
- MAGETWO-57905: Compiler Performance Optimization for 2.1

omiroshnichenko pushed a commit to omiroshnichenko/magento2 that referenced this pull request Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment