33383 GraphQL: add new mutation 'deleteCustomer' #33411

khrystynastolbova · 2021-07-02T14:58:31Z

Description (*)

Related Pull Requests

This PR added new mutation 'deleteCustomer'

Fixed Issues (if relevant)

Fixes Add deleteCustomer mutation #33383

Manual testing scenarios (*)

Generate customer token
Use customer tokens in the header of your GraphQL call
Run

mutation {
  deleteCustomer
}

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…rea"

m2-assistant · 2021-07-02T14:58:34Z

Hi @khrystynastolbova. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

khrystynastolbova · 2021-07-02T14:59:14Z

@magento run all tests

magento-automated-testing · 2021-07-02T14:59:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13

Thank you @khrystynastolbova for working on this one. Could you please review the questions and suggestions below?

app/code/Magento/CustomerGraphQl/Model/Resolver/DeleteCustomer.php

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/DeleteCustomerTest.php

eduard13 · 2021-07-06T06:43:30Z

app/code/Magento/CustomerGraphQl/Model/Resolver/DeleteCustomer.php

+        $isSecure = $this->registry->registry('isSecureArea');
+
+        $this->registry->unregister('isSecureArea');
+        $this->registry->register('isSecureArea', true);


I have a concern regarding the deprecated \Magento\Framework\Registry usage. Is there any alternative? Are we required to play with this configuration?

The check is located in magento/lib/internal/Magento/Framework/Model/ActionValidator/RemoveAction.php

public function isAllowed(AbstractModel $model) { $isAllowed = true; if ($this->registry->registry('isSecureArea')) { $isAllowed = true; } elseif (in_array($this->getBaseClassName($model), $this->protectedModels)) { $isAllowed = false; } return $isAllowed; }

ProtectedModels include the customer model too. In the file magento/app/code/Magento/Customer/etc/di.xml

<type name="Magento\Framework\Model\ActionValidator\RemoveAction"> <arguments> <argument name="protectedModels" xsi:type="array"> <item name="customer" xsi:type="string">Magento\Customer\Model\Customer</item> </argument> </arguments> </type>

To avoid deprecated \Magento\Framework\Registry, we can remove the Customer model from protected models in general or copy all protected models to graphQL/di.xml for all magento modules except the Customer one.

app/code/Magento/CustomerGraphQl/Model/Customer/DeleteCustomer.php

khrystynastolbova · 2021-07-08T11:48:13Z

Hi @eduard13. Thank you for your suggestions. I made changes except the deprecated \Magento\Framework\Registry usage.

khrystynastolbova · 2021-07-08T11:48:40Z

@magento run all tests

magento-automated-testing · 2021-07-08T11:48:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13

Could you please review the below suggestions as well?
Thank you.

eduard13 · 2021-07-12T13:58:34Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/DeleteCustomerTest.php

+use Magento\Integration\Api\CustomerTokenServiceInterface;
+
+/**
+ * Delete custom tests


Please adjust the description

eduard13 · 2021-07-12T13:58:51Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/DeleteCustomerTest.php

+     */
+    protected function setUp(): void
+    {
+        parent::setUp();


Is there any reason to call the parent method?

eduard13 · 2021-07-12T14:00:35Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/DeleteCustomerTest.php

+    public function testDeleteCustomerIfAccountIsLocked(): void
+    {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later');


Lets avoid long code lines

Suggested change

$this->expectExceptionMessage('The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later');

$this->expectExceptionMessage(

'The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later'

);

eduard13 · 2021-07-12T14:02:11Z

app/code/Magento/CustomerGraphQl/Model/Resolver/DeleteCustomer.php

+    ) {
+        $this->getCustomer = $getCustomer;
+        $this->deleteCustomer = $deleteCustomer;
+        $this->registry =$registry;


Suggested change

$this->registry =$registry;

$this->registry = $registry;

app/code/Magento/CustomerGraphQl/Model/Resolver/DeleteCustomer.php

engcom-Alfa · 2022-04-18T06:33:06Z

@magento run Static Tests, Magento Health Index

magento-automated-testing · 2022-04-18T06:33:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2022-04-18T10:02:13Z

✔️ QA Passed

Preconditions:

Have Magento latest installed
Make sure to have at least one working customer login.

Manual testing scenario:

Get the customer token thru GraphQL request.
GraphQl request with below mutation, and validate the response
mutation { deleteCustomer }

Before: ✖️ We had no GraphQL mutation at all to delete the customer.

After: ✔️ Customer with given token in the GraphQL request header gets deleted successfully

Additional Testing scenarios:

Deleted the customer thru above GraphQL mutation and tried to re-add the same customer from front end Create an account option.
Kept the customer UI account with active login and deleted the account, validated the logged browser session get wiped put automatically.

There are no any additional testing is required as part of regression since there is an automation cases already covered.

engcom-Alfa · 2022-04-18T10:07:12Z

Since there are a couple of auto jobs are getting failed, and so moving the ticket to Extended Testing.

Note: Before moving the ticket to Merge In Progress, we should have a devdoc updates request on this case!

…L_delete_customer

engcom-Charlie · 2022-05-13T10:05:03Z

@magento run all tests

magento-automated-testing · 2022-05-13T10:05:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-05-13T11:02:43Z

@magento run all tests

magento-automated-testing · 2022-05-13T11:02:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-05-16T07:11:31Z

@magento run Functional Tests B2B, Integration Tests, Magento Health Index

magento-automated-testing · 2022-05-16T07:11:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-05-18T10:58:34Z

The failing test of Functional B2B test is not part of this PR or not failing because of this PR changes.

Related to failed Magento Health Index test, raised approval JIRA ticket. Waiting for approval now.

Thank you!

…delete_customer

engcom-Charlie · 2022-08-17T08:06:23Z

@magento run all tests

magento-automated-testing · 2022-08-17T08:06:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-08-17T12:53:13Z

@magento run Magento Health Index , Functional Tests B2B, Functional Tests EE

magento-automated-testing · 2022-08-17T12:53:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-08-18T08:14:58Z

Raised new approval jira on adobe portal.

@cpartica can you please provide JIRA approval for Magento health Index.

Once we get the approval we can move this PR in Merge In Progress.

Thank you!

engcom-Charlie · 2022-09-15T12:55:20Z

Since we got all the approvals for magento health index on JIRA moving this PR to Merge in Progress.

Thank you!

33383 GraphQL: add new mutation 'deleteCustomer' #33411

khrystynastolbova added 3 commits June 30, 2021 16:52

33383 GraphQL: Delete customer account

777725e

33383 GraphQL: test coverage

eb5edd0

33383 GraphQL: fix error "Delete operation is forbidden for current a…

ab38512

…rea"

magento-engcom-team added Component: CustomerGraphQl Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 2, 2021

m2-community-project bot added the Progress: pending review label Jul 2, 2021

m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jul 5, 2021

eduard13 self-assigned this Jul 6, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 6, 2021

eduard13 requested changes Jul 7, 2021

View reviewed changes

m2-community-project bot added Progress: needs update Progress: review and removed Progress: review Progress: needs update labels Jul 7, 2021

33383: apply suggestions

aba7e20

khrystynastolbova requested a review from eduard13 July 8, 2021 12:08

eduard13 requested changes Jul 12, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jul 12, 2021

eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Jul 12, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Apr 18, 2022

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Apr 18, 2022

Merge remote-tracking branch 'magento2/2.4-develop' into 33383_graphQ…

6f3e185

…L_delete_customer

33383 Fixed static test failures

e283c7a

m2-community-project bot added Progress: pending approval and removed Progress: extended testing labels May 18, 2022

Merge remote-tracking branch 'origin/2.4-develop' into 33383_graphQL_…

29e8a49

…delete_customer

m2-community-project bot added Progress: accept and removed Progress: pending approval labels Sep 15, 2022

magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 23, 2022

Merge pull request #7885 from magento-gl/comm_78764_33411

61241d8

33383 GraphQL: add new mutation 'deleteCustomer' #33411

magento-devops-reposync-svc merged commit ec794f1 into magento:2.4-develop Sep 23, 2022

33383 GraphQL: add new mutation 'deleteCustomer' #33411

33383 GraphQL: add new mutation 'deleteCustomer' #33411

Uh oh!

Conversation

khrystynastolbova commented Jul 2, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 2, 2021

Uh oh!

khrystynastolbova commented Jul 2, 2021

Uh oh!

magento-automated-testing bot commented Jul 2, 2021

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eduard13 Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

khrystynastolbova Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

khrystynastolbova Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

khrystynastolbova commented Jul 8, 2021

Uh oh!

khrystynastolbova commented Jul 8, 2021

Uh oh!

magento-automated-testing bot commented Jul 8, 2021

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

engcom-Alfa commented Apr 18, 2022

Uh oh!

magento-automated-testing bot commented Apr 18, 2022

Uh oh!

engcom-Alfa commented Apr 18, 2022

Uh oh!

engcom-Alfa commented Apr 18, 2022

Uh oh!

engcom-Charlie commented May 13, 2022

Uh oh!

magento-automated-testing bot commented May 13, 2022

Uh oh!

engcom-Charlie commented May 13, 2022

Uh oh!

magento-automated-testing bot commented May 13, 2022

Uh oh!

engcom-Charlie commented May 16, 2022

Uh oh!

magento-automated-testing bot commented May 16, 2022

engcom-Charlie commented May 18, 2022 •

edited

Loading

engcom-Charlie commented Aug 18, 2022 •

edited

Loading