[Customer] Provides a Patch for Backend Model of Adminhtml #7885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tomers in the adminhtml.
|
It doesn't looks like good solution |
|
Hello ihor-sviziev, Could you please explain why you think that its a bad solution? I couldnt find another solution for loading the Backend-Model of the Customer Attribute in the DataProvider. Greetings |
|
@EliasKotlyar I think collection should execute this method if it's needed. |
|
Agree with @ihor-sviziev. It is not a responsibility of the data provider |
antonkril
suggested changes
Jan 10, 2017
|
@EliasKotlyar hi, verifying this pull request and it seems there outstanding items from the previous reviewers. Are you currently working on updating the code? |
|
@EliasKotlyar thank you for your contribution. Unfortunately we can not accept this PR in current state. Thank you |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 23, 2022
33383 GraphQL: add new mutation 'deleteCustomer' #33411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a Bugfix for loading the backend-model of the customers in the adminhtml.