Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions app/code/Magento/Theme/Block/Html/Header.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

namespace Magento\Theme\Block\Html;

use Magento\Framework\Escaper;

/**
* Html page header block
*
Expand All @@ -14,6 +16,27 @@
*/
class Header extends \Magento\Framework\View\Element\Template
{
/**
* @var Escaper
*/
protected $escaper;

/**
* Constructor
*
* @param \Magento\Framework\View\Element\Template\Context $context
* @param Magento\Framework\Escaper $escaper
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
\Magento\Framework\Escaper $escaper,
array $data = []
) {
$this->escaper = $escaper;
parent::__construct($context, $data);
}

/**
* Current template name
*
Expand All @@ -34,6 +57,7 @@ public function getWelcome()
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}
$this->_data['welcome'] = $this->escaper->escapeQuote($this->_data['welcome'], true);
return __($this->_data['welcome']);
}
}
18 changes: 16 additions & 2 deletions app/code/Magento/Theme/Test/Unit/Block/Html/HeaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Magento\Theme\Block\Html\Header;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Magento\Framework\Escaper;

class HeaderTest extends TestCase
{
Expand All @@ -27,6 +28,11 @@ class HeaderTest extends TestCase
*/
protected $scopeConfig;

/**
* @var Escaper|MockObject
*/
private $escaper;

protected function setUp(): void
{
$context = $this->getMockBuilder(Context::class)
Expand All @@ -38,10 +44,13 @@ protected function setUp(): void
->disableOriginalConstructor()
->getMock();
$context->expects($this->once())->method('getScopeConfig')->willReturn($this->scopeConfig);

$this->escaper = $this->createPartialMock(Escaper::class, ['escapeQuote']);
$this->unit = (new ObjectManager($this))->getObject(
Header::class,
['context' => $context]
[
'context' => $context,
'escaper' => $this->escaper
]
);
}

Expand All @@ -51,6 +60,11 @@ public function testGetWelcomeDefault()
->with('design/header/welcome', ScopeInterface::SCOPE_STORE)
->willReturn('Welcome Message');

$this->escaper->expects($this->once())
->method('escapeQuote')
->with('Welcome Message', true)
->willReturn('Welcome Message');

$this->assertEquals('Welcome Message', $this->unit->getWelcome());
}
}
24 changes: 13 additions & 11 deletions app/code/Magento/Theme/view/frontend/templates/html/header.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -10,32 +10,34 @@
*/
$welcomeMessage = $block->getWelcome();
?>
<?php if ($block->getShowPart() == 'welcome') : ?>
<?php if ($block->getShowPart() == 'welcome'): ?>
<li class="greet welcome" data-bind="scope: 'customer'">
<!-- ko if: customer().fullname -->
<span class="logged-in"
data-bind="text: new String('<?= $escaper->escapeHtml(__('Welcome, %1!', '%1')) ?>').replace('%1', customer().fullname)">
data-bind="text: new String('<?= $escaper->escapeHtml(__('Welcome, %1!', '%1')) ?>').
replace('%1', customer().fullname)">
</span>
<!-- /ko -->
<!-- ko ifnot: customer().fullname -->
<span class="not-logged-in"
data-bind="html: '<?= $escaper->escapeHtmlAttr($welcomeMessage) ?>'"></span>
data-bind="text: '<?= $escaper->escapeHtml($welcomeMessage) ?>'"></span>
<?= $block->getBlockHtml('header.additional') ?>
<!-- /ko -->
</li>
<?php // phpcs:ignore Magento2.Legacy.PhtmlTemplate ?>
<script type="text/x-magento-init">
{
"*": {
"Magento_Ui/js/core/app": {
"components": {
"customer": {
"component": "Magento_Customer/js/view/customer"
{
"*": {
"Magento_Ui/js/core/app": {
"components": {
"customer": {
"component": "Magento_Customer/js/view/customer"
}
}
}
}
}
}
</script>
<?php elseif ($block->getShowPart() == 'other') :?>
<?php elseif ($block->getShowPart() == 'other'): ?>
<?= $block->getChildHtml() ?>
<?php endif ?>
3 changes: 1 addition & 2 deletions app/code/Magento/Translation/Model/Inline/Parser.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Parser implements ParserInterface
/**
* data-translate html element attribute name
*/
const DATA_TRANSLATE = 'data-translate';
public const DATA_TRANSLATE = 'data-translate';

/**
* @var Escaper
Expand Down Expand Up @@ -688,7 +688,6 @@ private function _otherText()
],
JSON_HEX_QUOT
);

$spanHtml = $this->_getDataTranslateSpan(
'[' . $this->escaper->escapeHtmlAttr($translateProperties) . ']',
$matches[1][0]
Expand Down