fix: #14495 Allow custom varchar attributes for customer grid #36663

amenk · 2022-12-22T09:35:53Z

See the issues #14495 for details

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Customer export not work with custom attribute #14495

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
[no] All new or changed code is covered with unit/integration tests (if applicable)
[no] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[t.b.d] All automated tests passed successfully (all builds are green)

* As described in the issue, it does not make sense to use the backend-type for the UI-component data type, because those do not exist necessarily * Changed it to frontend_input

m2-assistant · 2022-12-22T09:35:55Z

Hi @amenk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

amenk · 2022-12-23T07:03:10Z

@magento run all tests

magento-automated-testing · 2022-12-23T07:03:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

swnsma · 2022-12-24T12:59:13Z

@magento run all tests

magento-automated-testing · 2022-12-24T12:59:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

swnsma

Hi @amenk,
Thank you for your contribution!

Could you please check failed test, seems it may have relation to functionality you are changing.

amenk · 2022-12-25T11:37:39Z

Failing test:

magento2/app/code/Magento/Customer/Test/Unit/Ui/Component/Listing/ColumnsTest.php

Line 160 in 1c553ec

public function testPrepareWithUpdateColumn(): void

amenk · 2022-12-25T11:43:03Z

@magento run Unit Tests

magento-automated-testing · 2022-12-25T11:43:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

amenk · 2022-12-25T16:09:24Z

Unit test are green now
@magento run all tests

magento-automated-testing · 2022-12-25T16:09:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

amenk · 2022-12-25T19:55:55Z

@magento run Functional Tests CE

magento-automated-testing · 2022-12-25T19:56:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

swnsma · 2022-12-26T10:23:37Z

@magento run Functional Tests B2B,Functional Tests CE

magento-automated-testing · 2022-12-26T10:23:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

swnsma · 2022-12-26T16:20:50Z

@magento run Functional Tests B2B

magento-automated-testing · 2022-12-26T16:20:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-23T11:32:14Z

@amenk @swnsma
Thanks for the collaboration & contribution!

✔️ QA Passed
fix: #14495 Allow custom varchar attributes for customer grid

Manual Scenario Steps
Steps to Reproduce

Add new customer attribute whose code is varchar_attribute, Input Type => Text Field, Add to Column Options => Yes, Use in Filter Options => Yes.
Define the varchar_attribute in the customer_listing.xml in sample module
Flush cache and reindex
Export the customer data at the Customer listing page.

Before: ✖️

After: ✔️
Able to export customers.

Hence moving to Merge In Progress

engcom-Charlie · 2023-01-31T17:37:51Z

It seems bot moved this PR from Merge in Progress to Ready for Testing hence moving it back.

fix: magento#14495 Allow custom varchar attributes for customer grid

efc74cd

* As described in the issue, it does not make sense to use the backend-type for the UI-component data type, because those do not exist necessarily * Changed it to frontend_input

amenk mentioned this pull request Dec 22, 2022

Customer export not work with custom attribute #14495

Closed

swnsma self-requested a review December 24, 2022 12:57

Merge branch '2.4-develop' into patch-18

667883a

swnsma requested changes Dec 24, 2022

View reviewed changes

m2-community-project bot assigned swnsma Dec 24, 2022

m2-community-project bot added the Progress: needs update label Dec 24, 2022

fix: magento#14495 Adapt test to expect frontendInput

793a9fc

swnsma approved these changes Dec 26, 2022

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Dec 26, 2022

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 27, 2022

engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 27, 2022

engcom-Echo self-assigned this Jan 20, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 20, 2023

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Jan 23, 2023

engcom-Charlie self-assigned this Jan 31, 2023

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Jan 31, 2023

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Jan 31, 2023

magento-devops-reposync-svc merged commit 5bc55c6 into magento:2.4-develop Feb 14, 2023

fix: #14495 Allow custom varchar attributes for customer grid #36663

fix: #14495 Allow custom varchar attributes for customer grid #36663

Uh oh!

Conversation

amenk commented Dec 22, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 22, 2022

Uh oh!

amenk commented Dec 23, 2022

Uh oh!

magento-automated-testing bot commented Dec 23, 2022

Uh oh!

swnsma commented Dec 24, 2022

Uh oh!

magento-automated-testing bot commented Dec 24, 2022

Uh oh!

swnsma left a comment

Choose a reason for hiding this comment

Uh oh!

amenk commented Dec 25, 2022

Uh oh!

amenk commented Dec 25, 2022

Uh oh!

magento-automated-testing bot commented Dec 25, 2022

Uh oh!

amenk commented Dec 25, 2022

Uh oh!

magento-automated-testing bot commented Dec 25, 2022

Uh oh!

amenk commented Dec 25, 2022

Uh oh!

magento-automated-testing bot commented Dec 25, 2022

Uh oh!

swnsma commented Dec 26, 2022

Uh oh!

magento-automated-testing bot commented Dec 26, 2022

Uh oh!

swnsma commented Dec 26, 2022

Uh oh!

magento-automated-testing bot commented Dec 26, 2022

Uh oh!

engcom-Echo commented Jan 23, 2023

Uh oh!

engcom-Charlie commented Jan 31, 2023

Uh oh!

Uh oh!