Skip to content

fix: #14495 Allow custom varchar attributes for customer grid #36663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2023
Merged

fix: #14495 Allow custom varchar attributes for customer grid #36663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efc74cd
fix: #14495 Allow custom varchar attributes for customer grid
amenk Dec 22, 2022
667883a
Merge branch '2.4-develop' into patch-18
swnsma Dec 24, 2022
793a9fc
fix: #14495 Adapt test to expect frontendInput
amenk Dec 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Customer/Test/Unit/Ui/Component/Listing/ColumnsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public function testPrepareWithAddColumn(): void
public function testPrepareWithUpdateColumn(): void
{
$attributeCode = 'billing_attribute_code';
$backendType = 'backend-type';
$frontendInput = 'text';
$attributeData = [
'attribute_code' => 'billing_attribute_code',
'frontend_input' => 'text',
Expand Down Expand Up @@ -211,7 +211,7 @@ public function testPrepareWithUpdateColumn(): void
'config',
[
'name' => $attributeCode,
'dataType' => $backendType,
'dataType' => $frontendInput,
'filter' => [
'filterType' => 'text',
'conditionType' => 'like',
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Customer/Ui/Component/Listing/Columns.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function updateColumn(array $attributeData, $newAttributeCode)
$component->getData('config'),
[
'name' => $newAttributeCode,
'dataType' => $attributeData[AttributeMetadata::BACKEND_TYPE],
'dataType' => $attributeData[AttributeMetadata::FRONTEND_INPUT],
'visible' => (bool)$attributeData[AttributeMetadata::IS_VISIBLE_IN_GRID]
]
);
Expand Down