Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add vendor directory to .gitignore #414

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

Flyingmana commented Nov 15, 2013

never ever put your vendor directory into your vcs

@Flyingmana Flyingmana add vendor directory to .gitignore
# never ever put your vendor directory into your vcs
bf9de2c
Contributor

maksek commented Nov 20, 2013

@Flyingmana why do i need to put the directory in gitignore? if i don't use folder name "vendor"? :)

Contributor

Flyingmana commented Nov 20, 2013

because magento starts to use composer and in future sure will use it to install libraries and so on.

composer puts all this libraries and so on inside the vendor directory. So if you use Composer, you will need to ignore the directory composer uses.

(thats configurable, vendor is only the default used one)

Is this enough as an answer?

Contributor

maksek commented Nov 20, 2013

@Flyingmana, it is enough as an answer, does it make more sense to add it into .gitignore after officially Composer will be introduced within magento packages?

Contributor

Flyingmana commented Nov 20, 2013

we have already an composer.json so now is a good time for adding also the vendor directory to .gitignore

Member

SchumacherFM commented Dec 20, 2013

This Magento2 composer.json should not be treated as the root project and therefore you have to avoid putting vendor into this .gitignore.

Create your own root composer.json/repository and add there vendor to your gitignore and make Magento2 as a required module. That setup makes it also easy to update Magento2 to different versions.

Contributor

Flyingmana commented Dec 20, 2013

I see, but commonly the unit-tests should work outside the context of a project.
So as long as there are unit-tests which should run standalone inside this project, you will need to load the required libraries (currently zero, but they will increase with rework the /lib directory)
So in the end, you will still have situations, where you need to ignore vendor.

Contributor

verklov commented Jan 21, 2014

@Flyingmana , thank you for reporting this issue! We are considering using Composer in Magento 2. Please watch the most fresh code we are deploying each Friday to the GitHub for updates.

Contributor

verklov commented Sep 10, 2014

The team processed this pull request and added vendor directory to .gitignore. We are closing this ticket now. Thanks again for your contribution!

@verklov verklov closed this Sep 10, 2014

@magento-team magento-team pushed a commit that referenced this pull request Mar 11, 2016

@rganin rganin Merge pull request #414 from magento-troll/Troll_S53
[Troll] Sprint 53
ea578b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment