Cast string SKUs back to string #5859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array keys cast to integer on string SKUs that could represent a PHP integer, however the Mysql comparison is string based for which - to prevent a cast in Mysql - it needs string quotes. These string quotes then need again the $sku as string. This is fixed by casting to string. Background: If you import many records with SKU that are numeric strings, Mysql performance is impacted negatively.
|
Reference: Reported against 2.1 in Enterprise Gold Support in Ticket #03187206 |
|
In my opinion at this time Magento developers are considering this as planning to fix for a future release of Magento and I have the feeling that they are not able to give a time frame on which release it would be but it should be in the next two ones. |
|
@tkn98 Thank you for contribution, closing as fix is already present in the mainline. |
|
@vrann: Thanks for the update and taking care. This one was long-awaited in one of our projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array keys cast to integer on string SKUs that could represent a PHP integer, however the Mysql comparison is string based for which - to prevent a cast in Mysql - it needs string quotes. These string quotes then need again the $sku as string.
This is fixed by casting to string.
Background: If you import many records with SKU that are numeric strings, Mysql performance is impacted negatively.