Fix product import sku field data type bug #7961
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7904. Always convert SKU to string.
Without the quotes SKU field on the left is being converted to numeric so it drops trailing characters. Then the numeric comparison sees the 13020663105 and 13020663105SL as the same numbers.
This happens because earlier SKUs are being used as array keys, and array keys, if it is possible, are converted to integer by PHP http://php.net/manual/en/language.types.array.php:
So if the function is using these keys, they must be manually cast to string (because all SKUs should always be treated as string?).