Controller Stub #14
Controller Stub #14
Conversation
…ll be used for testing
tjwiebell
force-pushed
the
feature/controller
branch
from
b646f70 to
38c7032
Compare
…to local PHP server
src/Controller.php
Outdated
| * | ||
| * @return \Zend\Http\Response | ||
| */ | ||
| public function run(): \Zend\Http\Response |
There was a problem hiding this comment.
My thought was this would be a good use case for __invoke() but I'm not absolutely stuck on that idea.
There was a problem hiding this comment.
Made this change assuming this would be the only public method. I'm not a fan of calling $controller() in bin/upward, if you have a better naming convention.
There was a problem hiding this comment.
🤷♂️ Naming stuff is one of the two hard things in programming.
Calling this class a "Controller" was the closest concept I could think of for it's purpose, but I welcome any better ideas.
…tion - Pass configuration to controller captured from environment variable - Fix package.json warnings
bin/upward
Outdated
| if (!$upwardConfig) { | ||
| // this appears to violate the spec, since we can't kill the server until we receive a request | ||
| // will leave here for right now until we can discuss with Z | ||
| posix_kill(posix_getpid(), SIGKILL); |
There was a problem hiding this comment.
We're sending a KILL signal back to ourselves? That seems bit like overkill.
Seriously though, I think the exit(1) below should be just as effective and a lot cleaner than this line. Either way, I get the feeling that having both is redundant.
There was a problem hiding this comment.
Yeah, I think this needs discussed further. Technically the server should never start if config is missing or malformed, but given the current logic, that validation would have to be in that shell script that starts the server.
This doesn't conform to the spec now anyway, so I'll just remove the SIGKILL.
…ctionality with James - Refactor after renaming of DefinitionIterator - Write unit test for Controller
Added 7.x version of symfony yaml in the dependency list
Begin work stubbing out the entry point for this app