Conversation
Member
|
Why disable cloudfront discovery? |
MariuszJozwiak
force-pushed
the
dev-fixcloudfront
branch
2 times, most recently
from
0aa3463 to
4d7b783
Compare
MariuszJozwiak
force-pushed
the
dev-fixcloudfront
branch
2 times, most recently
from
9a5e82a to
c221257
Compare
Szpadel
reviewed
Apr 2, 2025
Member
Szpadel
left a comment
Szpadel
left a comment
There was a problem hiding this comment.
Are you sure this works as intended?
group_vars/all.yml
Outdated
| value: "https://{{ aws_cloudfront_distribution_domain | default('') }}/" | ||
| default: "{{ aws_cloudfront_domain_aliases | default([]) | length > 0 }}" | ||
| enabled: "{{ aws_cloudfront_distribution_domain | default(false) is string }}" | ||
| enabled: "{{ aws_cloudfront_distribution_domain is string and aws_cloudfront_distribution_create | default(false) | bool }}" |
Member
There was a problem hiding this comment.
why do we need here this | default(false) | bool?
what case is not handled with? aws_cloudfront_distribution_domain is string and aws_cloudfront_distribution_create
Contributor
Author
There was a problem hiding this comment.
Removed and tested
MariuszJozwiak
force-pushed
the
dev-fixcloudfront
branch
from
c221257 to
145c2d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was missing rule that execute cloudfront every time even when it should be skipped.