Skip to content

Fix: estimate preset dimensions#1338

Open
Kr1491 wants to merge 3 commits into
magic-peach:mainfrom
Kr1491:fix/export-estimate-preset-dimensions
Open

Fix: estimate preset dimensions#1338
Kr1491 wants to merge 3 commits into
magic-peach:mainfrom
Kr1491:fix/export-estimate-preset-dimensions

Conversation

@Kr1491
Copy link
Copy Markdown
Contributor

@Kr1491 Kr1491 commented May 28, 2026

Description

PRESET_DIMENSIONS in src/lib/exportEstimate.ts used keys like "1080p", "720p", "square-1080" which don't match any actual preset IDs in src/lib/presets.ts. This caused getOutputDimensions() to always fall back to 1920×1080, making the export size estimate wrong for every preset except Landscape 16:9.

Fixed by updating all keys to match the actual preset IDs and adding all missing presets.

Related Issue

Closes #1156

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: @Kr1491
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Kr1491!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts labels May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

✅ PR Format Check Passed — @Kr1491

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added type:bug Bug fix type:docs Documentation type:feature New feature type:refactor Code refactor labels May 28, 2026
@Kr1491 Kr1491 changed the title Fix/export estimate preset dimensions Fix: estimate preset dimensions May 28, 2026
@Kr1491
Copy link
Copy Markdown
Contributor Author

Kr1491 commented May 29, 2026

Hi @magic-peach ! can you look into this pr, thank you !

@Kr1491
Copy link
Copy Markdown
Contributor Author

Kr1491 commented May 30, 2026

hey @magic-peach can you please look into this pr, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Export size estimate always uses 1920×1080 — PRESET_DIMENSIONS keys don't match actual preset IDs

1 participant