Skip to content

Feat/video fade transitions#1528

Open
nancy-verma780 wants to merge 2 commits into
magic-peach:mainfrom
nancy-verma780:feat/video-fade-transitions
Open

Feat/video fade transitions#1528
nancy-verma780 wants to merge 2 commits into
magic-peach:mainfrom
nancy-verma780:feat/video-fade-transitions

Conversation

@nancy-verma780
Copy link
Copy Markdown

Overview

This PR implements video fade-in (from black) and fade-out (to black) transition options at the start and end of the exported video clip inside the FFmpeg processing sequence.

Key Changes

  • FFmpeg Worker Optimization: Enhanced buildVideoFilter within src/lib/ffmpeg.worker.ts to append dynamic fade=t=in:st=0:d={dur} and fade=t=out:st={start}:d={dur} parameters based on duration parameters.
  • UI Configuration Parameters: Added responsive numeric duration controllers inside ExportSettings.tsx to let consumers customize transition timing (up to 5 seconds) dynamically with step options.
  • Fallback Configurations: Handled clip duration bounds checking to prevent calculation errors on shorter assets.

Closes #124

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

@nancy-verma780 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

👋 Thanks for your PR, @nancy-verma780!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

⚠️ PR Format Issues — @nancy-verma780

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:design UI/UX design labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:advanced Advanced level - 55 pts type:design UI/UX design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add video fade in/out transitions

1 participant