Skip to content

fix: add visual disabled state to export button#360

Merged
magic-peach merged 7 commits into
magic-peach:mainfrom
aryanm9026:fix/export-button-disabled
May 16, 2026
Merged

fix: add visual disabled state to export button#360
magic-peach merged 7 commits into
magic-peach:mainfrom
aryanm9026:fix/export-button-disabled

Conversation

@aryanm9026
Copy link
Copy Markdown
Contributor

Description

This PR updates the Export button in VideoEditor.tsx to include clear visual styling and accessibility attributes when disabled, as requested in the issue's Acceptance Criteria.

Resolves #235

Changes Made

  • Added opacity-40 to the disabled state Tailwind classes so the button visually greys out when no file is loaded.
  • Added the aria-disabled={!file} attribute to improve accessibility.
  • Ensured the cursor-not-allowed class works correctly on hover during the disabled state without conflicting with the active state styles.

Screenshots

image

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

@aryanm9026 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@magic-peach magic-peach added bug Something isn't working correctly ui/ux User interface or experience improvement gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts size: small Small issue - a few lines of code needs-review Needs maintainer review gssoc:approved Approved for GSSoC'26 type:bug Bug fix type:design UI/UX design and removed bug Something isn't working correctly ui/ux User interface or experience improvement size: small Small issue - a few lines of code needs-review Needs maintainer review labels May 15, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @aryanm9026! The CI build check hasn't run on this PR yet — this usually happens when the PR was opened before the CI was fully set up, or if the branch hasn't been updated recently.

To trigger the build check, please rebase onto the latest main:

git fetch origin
git rebase origin/main
git push --force-with-lease

This will re-trigger CI. If you hit any merge conflicts in src/app/page.tsx, keep the version from main (no <main> wrapper around <VideoEditor />).

Once CI passes and the Vercel deployment is authorized, we'll review and merge. 🚀

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 and removed gssoc:approved Approved for GSSoC'26 labels May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

✅ PR Format Check Passed — @aryanm9026

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added the ui/ux User interface or experience improvement label May 16, 2026
@aryanm9026
Copy link
Copy Markdown
Contributor Author

Hey @magic-peach , i fixed it, i hope it works now.

@magic-peach magic-peach merged commit 90cbdf4 into magic-peach:main May 16, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design ui/ux User interface or experience improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Add disabled state styling to Export button when no file is selected

2 participants