Add TypeScript typecheck Github Actions workflow#366
Conversation
|
@shivangii123 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@shivangii123 please fix the failing tests |
|
Hey @shivangii123! The TypeScript typecheck workflow addition is clean and exactly what the project needs 🙏 The build is failing because your branch was based on an old version of git fetch upstream main
git rebase upstream/main
git push --force-with-leaseAfter rebasing, the build should pass — your
|
|
@shivangii123 please fix the build issues |
|
Hey @shivangii123! The build is failing because your branch has a conflict with Error — Your PR was opened before a critical fix was merged to Fix — rebase onto main: git fetch origin
git rebase origin/mainResolve the Your TypeScript typecheck workflow itself is a solid addition — just needs the rebase to unblock CI. 🚀 |
|
Hi @shivangii123 👋 The CI build is currently failing on this PR. Could you check the build logs and fix the issue? Once the build passes, this will be ready to merge. You can view the build failure by clicking on the failed check in the PR. Please fix the errors and push an update. 🙂 |
|
Hey @shivangii123, the TypeScript typecheck workflow is a great addition! However, the build check is currently failing — likely because the project's existing code has TypeScript errors that would be caught by |
|
|
Merged! ✅ The TypeScript typecheck workflow adds an important CI gate. Type errors will now be caught before they reach main. |
Changes Made
.github/workflows/typecheck.ymlpushandpull_requestCloses #59