Skip to content

Add TypeScript typecheck Github Actions workflow#366

Merged
magic-peach merged 3 commits into
magic-peach:mainfrom
shivangii123:add-typecheck-workflow
May 17, 2026
Merged

Add TypeScript typecheck Github Actions workflow#366
magic-peach merged 3 commits into
magic-peach:mainfrom
shivangii123:add-typecheck-workflow

Conversation

@shivangii123

Copy link
Copy Markdown
Contributor

Changes Made

  • Added .github/workflows/typecheck.yml
  • Added GitHub Actions workflow for TypeScript type checking
  • Runs on both push and pull_request
  • Uses Bun for dependency management

Closes #59

@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

@shivangii123 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@shivangii123 shivangii123 changed the title Add Typescript typecheck Github Actions workflow Add TypeScript typecheck Github Actions workflow May 15, 2026
@magic-peach magic-peach added ci/cd Continuous integration and deployment gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts size: small Small issue - a few lines of code needs-review Needs maintainer review labels May 15, 2026
@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reframe Error Error May 15, 2026 11:28am

@magic-peach

Copy link
Copy Markdown
Owner

@shivangii123 please fix the failing tests

@magic-peach

Copy link
Copy Markdown
Owner

Hey @shivangii123! The TypeScript typecheck workflow addition is clean and exactly what the project needs 🙏

The build is failing because your branch was based on an old version of page.tsx that had a syntax error (already fixed on main). Please rebase:

git fetch upstream main
git rebase upstream/main
git push --force-with-lease

After rebasing, the build should pass — your typecheck.yml doesn't change any code, so the only failure was the stale page.tsx.

Tagged: gssoc'26 needs-review

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 type:devops CI/CD and DevOps and removed ci/cd Continuous integration and deployment size: small Small issue - a few lines of code needs-review Needs maintainer review labels May 16, 2026
@magic-peach

Copy link
Copy Markdown
Owner

@shivangii123 please fix the build issues

@magic-peach

Copy link
Copy Markdown
Owner

Hey @shivangii123! The build is failing because your branch has a conflict with main:

Error — src/app/page.tsx:

Expression expected — Syntax Error

Your PR was opened before a critical fix was merged to main. Your branch still has the old broken page.tsx.

Fix — rebase onto main:

git fetch origin
git rebase origin/main

Resolve the page.tsx conflict by keeping the main version (no <main> wrapper). Then git push --force-with-lease.

Your TypeScript typecheck workflow itself is a solid addition — just needs the rebase to unblock CI. 🚀

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 and removed gssoc:approved Approved for GSSoC'26 labels May 16, 2026
@magic-peach

Copy link
Copy Markdown
Owner

Hi @shivangii123 👋 The CI build is currently failing on this PR. Could you check the build logs and fix the issue? Once the build passes, this will be ready to merge.

You can view the build failure by clicking on the failed check in the PR. Please fix the errors and push an update. 🙂

@magic-peach magic-peach added needs-fixes PR has issues that need to be fixed quality:clean Well-implemented, clean code labels May 16, 2026
@magic-peach

Copy link
Copy Markdown
Owner

Hey @shivangii123, the TypeScript typecheck workflow is a great addition! However, the build check is currently failing — likely because the project's existing code has TypeScript errors that would be caught by bunx tsc --noEmit. Please either: (1) ensure the repo passes tsc --noEmit before this check is enforced, or (2) add continue-on-error: true as an intermediate step. Also the workflow file is missing a newline at the end of file. Please rebase onto main and address the build failure.

@magic-peach magic-peach added the level:beginner Beginner level - 20 pts label May 16, 2026
@github-actions

github-actions Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @shivangii123

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@magic-peach magic-peach removed the level:beginner Beginner level - 20 pts label May 17, 2026
@magic-peach magic-peach removed the needs-fixes PR has issues that need to be fixed label May 17, 2026
@magic-peach magic-peach merged commit 7777eae into magic-peach:main May 17, 2026
3 of 4 checks passed
@magic-peach

Copy link
Copy Markdown
Owner

Merged! ✅ The TypeScript typecheck workflow adds an important CI gate. Type errors will now be caught before they reach main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts quality:clean Well-implemented, clean code type:devops CI/CD and DevOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Add GitHub Actions workflow for TypeScript type checking

2 participants