feat: add visual range slider to TrimControl for better UX#546
feat: add visual range slider to TrimControl for better UX#546rahul616sama wants to merge 9 commits into
Conversation
|
@rahul616sama is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @rahul616sama!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @rahul616samaBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
This PR also includes the custom rotation slider feature. |
|
This PR also includes the custom rotation slider feature. |
|
Hey @rahul616sama! This PR has rm package-lock.json
git add package-lock.json
git commit -m "chore: remove package-lock.json"
git pushOnce removed and CI passes, the RotateControl and TrimControl changes will be reviewed. Thanks! |
|
Hey @rahul616sama! The CI build failed for this PR with an accessibility lint error: This means a
For example: <label htmlFor="rotate-slider">Rotation</label>
<input id="rotate-slider" type="range" ... />Fix this and push again to re-run CI. |
|
Hey @rahul616sama! The visual range slider for TrimControl is a good UX improvement. This PR has:
Please rebase and fix build errors. |
|
Hey @rahul616sama! The build check is failing on this PR. Please fix the build errors and push again. Check the CI run for specific error details. |
|
Hey @magic-peach I've addressed all the feedback:
Ready for review! 🙏 |
|
Hey @rahul616sama! This PR looks good in terms of code structure, but the build/lint/typecheck CI hasn't run yet. Please rebase onto the latest git fetch upstream
git rebase upstream/main
git push --force-with-leaseOnce CI passes, we'll review and merge! |
|
Hey @magic-peach Done — rebased onto the latest main and force-pushed. CI should trigger now. Let me know if anything else is needed |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@rahul616sama almost all tests are failing please fix them |
|
Hey @magic-peach On it — running the tests locally to identify and fix the failures. Will push a fix shortly! |
|
Hey @magic-peach Fixed the merge conflict in TrimControl.tsx and pushed ✅. All tests passing locally. Could you approve the workflows when you get a chance? 🙏 |
|
Hey @rahul616sama! 👋 We've added a new requirement for all PRs: a screen recording showing your changes working on your local machine must be attached before a PR can be merged. Please add a recording to this PR that shows:
How to record:
Once you have the recording, drag the file directly into a comment on this PR, or paste a Loom link. This is now a hard requirement — see CONTRIBUTING.md for full details. Thanks for contributing to Reframe! 🎬 |
|
Hey @magic-peach Here's the screen recording showing the visual range slider working on my local machine (bun run dev) App running at localhost:3000 Ready for review! Editing_.WhatsApp.Video.2026-05-17.at.12.43.59.PM.mp4._.Reframe.-.Brave.2026-05-19.11-27-40.mp4 |
|
Hey @magic-peach ..Ready for review! 🙏 |
|
For #660 Uploading Editing_ Editing_ WhatsApp Video 2026-05-17 at 12.43.59 PM.mp4 _ Reframe - Brave 2026-05-19 11-27-40.mp4 _ Reframe - Brave 2026-05-20 10-20-15.mp4… |
|
Hey @magic-peach Updated the PR to also close #660 — added a BeforeAfterSlider component that appears on the video preview whenever brightness, contrast, or saturation is adjusted. Screen recording attached showing it working. Ready for review |
Description
Added a visual dual-handle range slider to the TrimControl component so users can drag to set start/end times instead of typing manually.
Related Issue
Closes #537
Closes #666
Closes #660
Changes Made