Skip to content

feat: add undo toast for Reset all settings button#687

Open
vdadheech wants to merge 8 commits into
magic-peach:mainfrom
vdadheech:feat/reset-undo-toast
Open

feat: add undo toast for Reset all settings button#687
vdadheech wants to merge 8 commits into
magic-peach:mainfrom
vdadheech:feat/reset-undo-toast

Conversation

@vdadheech
Copy link
Copy Markdown

@vdadheech vdadheech commented May 18, 2026

Saves a snapshot of current settings before reset and shows a 5-second undo toast. Clicking Undo restores the previous state. Follows the Gmail-style 'snackbar undo' pattern instead of a blocking confirm dialog.

Closes #

Description

Related Issue

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username:
  • Contribution level (Beginner/Intermediate/Advanced):

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes
  • This PR is related to a valid issue

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

@vdadheech is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @vdadheech!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

✅ PR Format Check Passed — @vdadheech

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 18, 2026
@vdadheech vdadheech closed this May 18, 2026
@vdadheech vdadheech deleted the feat/reset-undo-toast branch May 18, 2026 21:09
@vdadheech vdadheech restored the feat/reset-undo-toast branch May 19, 2026 07:04
@vdadheech vdadheech deleted the feat/reset-undo-toast branch May 19, 2026 07:04
@vdadheech vdadheech restored the feat/reset-undo-toast branch May 19, 2026 07:04
@vdadheech vdadheech reopened this May 19, 2026
@vdadheech vdadheech marked this pull request as draft May 19, 2026 07:46
@github-actions github-actions Bot added the level:advanced Advanced level - 55 pts label May 19, 2026
@vdadheech vdadheech marked this pull request as ready for review May 19, 2026 19:22
@magic-peach magic-peach added the level:intermediate Intermediate level - 35 pts label May 21, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @vdadheech! CI hasn't run on this PR yet. Please rebase on main to trigger the build/lint/typecheck checks:

git fetch origin
git rebase origin/main
git push --force-with-lease

Also please attach a screen recording showing your change working at http://localhost:3000. Both CI passing and a recording are required before merge. See CONTRIBUTING.md for details.

@magic-peach magic-peach removed level:intermediate Intermediate level - 35 pts level:advanced Advanced level - 55 pts type:bug Bug fix type:docs Documentation type:design UI/UX design labels May 23, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @vdadheech! This PR has merge conflicts with main that need to be resolved before review. Please rebase:

git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease

Once rebased and CI (build/lint/typecheck) passes, the undo toast feature will be reviewed. Thanks!

@magic-peach
Copy link
Copy Markdown
Owner

Hey @vdadheech! The undo toast pattern for the reset button is a clever UX idea (Gmail-style snackbar).

However, there are blockers:

  1. package-lock.json added — This is a hard reject. This project uses bun.lock exclusively. package-lock.json must be removed from the PR. It's also in the .gitignore.

  2. Empty PR description — Please fill in the related issue number, contribution level, and checklist.

  3. No CI checks — Build, lint, and typecheck haven't run.

  4. Merge conflicts — The PR is conflicting with main.

To fix:

  • Remove package-lock.json from your branch: git rm package-lock.json && git commit
  • Fill out the PR template
  • Rebase on latest main to resolve conflicts and trigger CI

Once these are fixed, the feature can be properly reviewed.

vdadheech added 3 commits May 29, 2026 19:13
Saves a snapshot of current settings before reset and shows a 5-second
undo toast. Clicking Undo restores the previous state. Follows the
Gmail-style 'snackbar undo' pattern instead of a blocking confirm dialog.

Closes #<issue-number>
@vdadheech vdadheech force-pushed the feat/reset-undo-toast branch from 3136036 to a9b475f Compare May 29, 2026 13:43
@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation labels May 29, 2026
@github-actions github-actions Bot added the level:advanced Advanced level - 55 pts label May 29, 2026
@vdadheech
Copy link
Copy Markdown
Author

#687 closed

@vdadheech vdadheech closed this May 29, 2026
@vdadheech vdadheech reopened this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts level:beginner Beginner level - 20 pts level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants