Skip to content

fix(ui): hide number input spinners to prevent value visibility overl…#778

Merged
magic-peach merged 1 commit into
magic-peach:mainfrom
Rucha0901:fix/spinner-visibility-776
May 20, 2026
Merged

fix(ui): hide number input spinners to prevent value visibility overl…#778
magic-peach merged 1 commit into
magic-peach:mainfrom
Rucha0901:fix/spinner-visibility-776

Conversation

@Rucha0901
Copy link
Copy Markdown
Contributor

Bug Summary

Closes #776

Numeric input fields in the customization panel show browser-native increment/decrement
spinner arrows that overlap with the entered value, making text partially or fully hidden —
especially noticeable in Chromium-based browsers (Brave, Chrome, Edge) on Windows.

Root Cause

<input type="number"> renders built-in spinner arrows inside the input box.
In narrow containers the arrows sit on top of the typed value, reducing readability.

Fix

Suppress the spinner UI with cross-browser Tailwind arbitrary-value classes added
directly to the affected inputs' className:

Class Browser
[appearance:textfield] Firefox
[&::-webkit-outer-spin-button]:appearance-none Chrome / Brave / Edge / Safari
[&::-webkit-inner-spin-button]:appearance-none Chrome / Brave / Edge / Safari

Keyboard ↑ / ↓ stepping is preserved — only the visual arrows are hidden.

Files Changed

File Inputs Fixed
src/components/TrimControl.tsx Start (sec), End (sec)
src/components/PresetSelector.tsx Custom Width (px), Custom Height (px)

Acceptance Criteria

  • Entered values are fully visible in all numeric inputs
  • No spinner arrows obstructing the text in Brave / Chrome / Edge
  • Firefox textfield appearance set correctly
  • Keyboard up/down key stepping still works
  • No TypeScript errors (tsc --noEmit passes clean)

…ap (magic-peach#776)

Browser-native increment/decrement arrows on <input type='number'> fields
overlap with entered values in narrow containers, making text hard to read.

Fix: suppress the spinner UI using cross-browser Tailwind arbitrary-value classes:
  - [appearance:textfield]                        — Firefox
  - [&::-webkit-outer-spin-button]:appearance-none — Chrome/Brave/Edge/Safari
  - [&::-webkit-inner-spin-button]:appearance-none — Chrome/Brave/Edge/Safari

Affected inputs:
  - TrimControl.tsx   — Start (sec) and End (sec) number fields
  - PresetSelector.tsx — Custom Width (px) and Height (px) fields

Keyboard up/down arrow key stepping still works; only the visual spinner
arrows are removed, which fully resolves the overlap/readability bug.

Closes magic-peach#776
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Rucha0901

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design labels May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Rucha0901!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reframe Ready Ready Preview, Comment May 20, 2026 2:45pm

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 quality:clean Well-implemented, clean code labels May 20, 2026
@magic-peach magic-peach merged commit 7167080 into magic-peach:main May 20, 2026
10 of 12 checks passed
jaygaikar-09 pushed a commit to jaygaikar-09/reframe that referenced this pull request May 21, 2026
…ap (magic-peach#776) (magic-peach#778)

Browser-native increment/decrement arrows on <input type='number'> fields
overlap with entered values in narrow containers, making text hard to read.

Fix: suppress the spinner UI using cross-browser Tailwind arbitrary-value classes:
  - [appearance:textfield]                        — Firefox
  - [&::-webkit-outer-spin-button]:appearance-none — Chrome/Brave/Edge/Safari
  - [&::-webkit-inner-spin-button]:appearance-none — Chrome/Brave/Edge/Safari

Affected inputs:
  - TrimControl.tsx   — Start (sec) and End (sec) number fields
  - PresetSelector.tsx — Custom Width (px) and Height (px) fields

Keyboard up/down arrow key stepping still works; only the visual spinner
arrows are removed, which fully resolves the overlap/readability bug.

Closes magic-peach#776

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>
Ayush-kathil pushed a commit to Ayush-kathil/reframe that referenced this pull request May 21, 2026
…ap (magic-peach#776) (magic-peach#778)

Browser-native increment/decrement arrows on <input type='number'> fields
overlap with entered values in narrow containers, making text hard to read.

Fix: suppress the spinner UI using cross-browser Tailwind arbitrary-value classes:
  - [appearance:textfield]                        — Firefox
  - [&::-webkit-outer-spin-button]:appearance-none — Chrome/Brave/Edge/Safari
  - [&::-webkit-inner-spin-button]:appearance-none — Chrome/Brave/Edge/Safari

Affected inputs:
  - TrimControl.tsx   — Start (sec) and End (sec) number fields
  - PresetSelector.tsx — Custom Width (px) and Height (px) fields

Keyboard up/down arrow key stepping still works; only the visual spinner
arrows are removed, which fully resolves the overlap/readability bug.

Closes magic-peach#776

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 level:beginner Beginner level - 20 pts quality:clean Well-implemented, clean code type:bug Bug fix type:design UI/UX design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix input value visibility issue caused by increment/decrement arrows in customization fields

2 participants