fix(ui): center Reset all settings button in settings panel (#773)#781
Open
Rucha0901 wants to merge 2 commits into
Open
fix(ui): center Reset all settings button in settings panel (#773)#781Rucha0901 wants to merge 2 commits into
Rucha0901 wants to merge 2 commits into
Conversation
…ach#773) The wrapper div around the Reset all settings button used justify-end, which right-aligned the button inside the settings panel container. Change justify-end to justify-center on the wrapper div so the button is perfectly centred, improving visual balance across all screen sizes. Closes magic-peach#773
|
@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Rucha0901!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @Rucha0901Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Owner
|
@Rucha0901 please resolve conflicts |
Owner
|
Hey @Rucha0901! The build, lint, and typecheck checks are all failing on this PR. Please run the following locally and fix any errors: bun run build
bun run lint
bunx tsc --noEmitAlso note this duplicates the work in PR #790 (which fixed the same issue and has been merged). Please check if your changes are still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Summary
Closes #773
The "RESET ALL SETTINGS" button in the right-side settings panel was
right-aligned due to
justify-endon its wrapper div, creating a visualimbalance inside the container.
Root Cause
In
src/components/VideoEditor.tsx, the wrapper around the reset button used: