fix: gif size export estimation fixed#807
Open
Vagventure wants to merge 7 commits into
Open
Conversation
Signed-off-by: Vagventure <ankitverma0366@gmail.com>
Signed-off-by: Vagventure <ankitverma0366@gmail.com>
…der metrics Signed-off-by: Vagventure <ankitverma0366@gmail.com>
…ne compilation failures Signed-off-by: Vagventure <ankitverma0366@gmail.com>
Signed-off-by: Vagventure <ankitverma0366@gmail.com>
Signed-off-by: Vagventure <ankitverma0366@gmail.com>
|
@Vagventure is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
level:intermediate
Contributor
👋 Thanks for your PR, @Vagventure!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @VagventureBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Owner
|
@Vagventure the tests are failing please fix |
Vagventure
changed the title
Vagventure
force-pushed
the
bug/gif-export-estimate-fix
branch
from
7c92ebe to
4ebae45
Compare
Contributor
Author
|
@magic-peach , i've fixed the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the file size calculation bug where selecting the newly implemented GIF export option would display a highly inaccurate prediction. Because GIFs lack the advanced temporal and inter-frame compression algorithms used by video containers like MP4 and WebM, their actual data footprint scales rapidly.
Changes Made:
src/lib/exportEstimate.ts: Updated the size calculation logic insideestimateExportSize()by implementing a dedicated check branch for thegifformat. When evaluating a GIF recipe, the estimator now uses an uncompressed frame-by-frame data coefficient scale rather than the traditional CRF/bitrate formula used for standard compressed video streams, ensuring the front-end file preview matches real-world export metrics.Related Issue
Closes #795
Type of Contribution
Participant Info
Screen Recording
Screen.Recording.2026-05-20.155838.mp4
Recording / Loom link:
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in