Skip to content

fix: resolve critical export, preview, trim and memory bugs#945

Open
Vedhant26 wants to merge 2 commits into
magic-peach:mainfrom
Vedhant26:fix/issue-930-critical-bugs
Open

fix: resolve critical export, preview, trim and memory bugs#945
Vedhant26 wants to merge 2 commits into
magic-peach:mainfrom
Vedhant26:fix/issue-930-critical-bugs

Conversation

@Vedhant26
Copy link
Copy Markdown

Hey folks! 👋 I've taken a deep dive into the critical bugs reported in #930 and put together this PR which resolves all four of the major issues affecting the editing pipeline.

Here's exactly what I've fixed:

  1. Export Size Estimation (Preset ID Mismatch): I've removed the hardcoded \PRESET_DIMENSIONS\ object which was out of sync with the actual IDs. The app now directly uses \getPresetById\ to ensure export sizes are predicted accurately for vertical and portrait formats.
  2. Preview Crop Geometry: I swapped the inverted logic for the \ ill\ crop mode. When the output is taller (e.g. 9:16), it correctly indicates left/right cropping, giving accurate visual feedback!
  3. Trim State Leak (NaNs): I created a dedicated \endInput\ state in the \TrimControl\ component. It now waits until all validations pass before firing \onChange, completely preventing invalid states (like \NaN) from bleeding into the global calculations.
  4. Thumbnail Strip Memory Usage (OOM fix): I dynamically capped the thumbnail generation interval based on the total video duration. This prevents the browser from generating hundreds of canvases and freezing on long videos.

I've tested these out locally and everything is super smooth and stable now. Let me know if there's anything else you need changed. Cheers! 🚀

Closes #930

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Vedhant26 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Vedhant26!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

✅ PR Format Check Passed — @Vedhant26

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix labels May 22, 2026
@Vedhant26
Copy link
Copy Markdown
Author

Issues resolved ! Ready to merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Multiple Critical Bugs Affecting Export Accuracy, Preview Geometry, Trim Stability, and Large Video Performance

1 participant