Fix: Prevent premature state update and export corruption in TrimControl#957
Merged
Merged
Conversation
|
@Sandeep6135 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Sandeep6135Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Sandeep6135!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
magic-peach
added
gssoc:approved
Owner
|
@Sandeep6135 please star the repo |
chavanGaneshDatta
pushed a commit
to chavanGaneshDatta/reframe
that referenced
this pull request
May 23, 2026
…rol (magic-peach#957) * Fix premature state update in TrimControl * Trigger CI recheck * Fix unexportable video bug for unknown durations
Ram-sah19
pushed a commit
to Ram-sah19/reframe
that referenced
this pull request
May 24, 2026
…rol (magic-peach#957) * Fix premature state update in TrimControl * Trigger CI recheck * Fix unexportable video bug for unknown durations
sahilsultane
pushed a commit
to sahilsultane/reframe
that referenced
this pull request
May 24, 2026
…rol (magic-peach#957) * Fix premature state update in TrimControl * Trigger CI recheck * Fix unexportable video bug for unknown durations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a critical state corruption bug in the video trimming workflow.
The Problem:
Previously, the
handleEndfunction inTrimControlupdated the globalrecipe.trimEndstate before validating the user's input. If a user entered an invalid value (resulting inNaN) or an out-of-bounds value, theNaNvalue was committed to the state despite the UI showing an error. This bypassed the pre-export validation (NaN > durationevaluates tofalse), passing corrupted state to FFmpeg and causing the video export to fail/crash.The Solution:
Moved the
onChange({ trimEnd: n })state dispatch to the very end of thehandleEndfunction. The global recipe state is now only updated after all input validation checks (likeisNaN, positive integer bounds, and duration checks) pass successfully.Testing:
recipe.Closes #954