Skip to content

Conversation

@GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Jan 15, 2023

Add Dex interactions and an implementation for Orca

Status Type ⚠️ Core Change Issue
Hold Feature No

Problem

In-game transaction and Dex is complicated

Solution

  • Implemented and IDex interface to abstract the dex interactions
  • Added an IDex implementation of Orca, following the Orca whirlpool typescript SDK

See Integration and Unit tests for examples of usage:

@coveralls
Copy link

coveralls commented Jan 15, 2023

Pull Request Test Coverage Report for Build 3924655004

  • 15 of 108 (13.89%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 80.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Solana.Unity.Wallet/PublicKey.cs 6 8 75.0%
src/Solana.Unity.Rpc/Core/Http/CrossHttpClient.cs 3 19 15.79%
src/Solana.Unity.Rpc/SolanaRpcClient.cs 0 24 0.0%
src/Solana.Unity.Rpc/TransactionUtils.cs 0 51 0.0%
Totals Coverage Status
Change from base Build 3892128390: -0.1%
Covered Lines: 5120
Relevant Lines: 6111

💛 - Coveralls

@GabrielePicco GabrielePicco merged commit 7f95cfd into master Jan 15, 2023
@GabrielePicco GabrielePicco deleted the feature/add-dex-implementation branch January 15, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants